fix bug with setInputMode

Author: sanny32

omodsim/controls/numericlineedit.cpp

@@ -74,8 +74,7 @@ NumericLineEdit::InputMode NumericLineEdit::inputMode() const
 ///
 void NumericLineEdit::setInputMode(InputMode mode)
 {
-    _inputMode = mode;
-    if(!_minValue.isValid() || !_maxValue.isValid())
+    if(!_minValue.isValid() || !_maxValue.isValid() || mode != _inputMode)
     {
         switch(mode)
         {
@@ -86,7 +85,7 @@ void NumericLineEdit::setInputMode(InputMode mode)
             break;
 
             case UInt32Mode:
-                _minValue = 0;
+                _minValue = 0U;
                 _maxValue = UINT_MAX;
             break;
 
@@ -111,6 +110,7 @@ void NumericLineEdit::setInputMode(InputMode mode)
             break;
         }
     }
+    _inputMode = mode;
     emit rangeChanged(_minValue, _maxValue);
 }
 

omodsim/dialogs/dialogwriteholdingregister.cpp

@@ -66,41 +66,36 @@ DialogWriteHoldingRegister::DialogWriteHoldingRegister(ModbusWriteParams& writeP
 
         case DataDisplayMode::FloatingPt:
         case DataDisplayMode::SwappedFP:
-            ui->lineEditValue->setInputRange(-FLT_MAX, FLT_MAX);
             ui->lineEditValue->setInputMode(NumericLineEdit::FloatMode);
             ui->lineEditValue->setValue(_writeParams.Value.toFloat());
         break;
 
         case DataDisplayMode::DblFloat:
         case DataDisplayMode::SwappedDbl:
-            ui->lineEditValue->setInputRange(-DBL_MAX, DBL_MAX);
             ui->lineEditValue->setInputMode(NumericLineEdit::DoubleMode);
             ui->lineEditValue->setValue(_writeParams.Value.toDouble());
         break;
 
         case DataDisplayMode::Int32:
         case DataDisplayMode::SwappedInt32:
-            ui->lineEditValue->setInputRange(INT_MIN, INT_MAX);
+            ui->lineEditValue->setInputMode(NumericLineEdit::Int32Mode);
             ui->lineEditValue->setValue(_writeParams.Value.toInt());
         break;
 
         case DataDisplayMode::UInt32:
         case DataDisplayMode::SwappedUInt32:
-            ui->lineEditValue->setInputRange(0U, UINT_MAX);
             ui->lineEditValue->setInputMode(NumericLineEdit::UInt32Mode);
             ui->lineEditValue->setValue(_writeParams.Value.toUInt());
         break;
 
         case DataDisplayMode::Int64:
         case DataDisplayMode::SwappedInt64:
-            ui->lineEditValue->setInputRange(INT64_MIN, INT64_MAX);
             ui->lineEditValue->setInputMode(NumericLineEdit::Int64Mode);
             ui->lineEditValue->setValue(_writeParams.Value.toLongLong());
         break;
 
         case DataDisplayMode::UInt64:
         case DataDisplayMode::SwappedUInt64:
-            ui->lineEditValue->setInputRange<quint64>(0, UINT64_MAX);
             ui->lineEditValue->setInputMode(NumericLineEdit::UInt64Mode);
             ui->lineEditValue->setValue(_writeParams.Value.toULongLong());
         break;