fix: make Sandbox instance selection responsive - #28
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking an instance previously waited for a detail request before changing the selection, then chained an event query into the same operation. A failed request made the picker appear unresponsive, and an event 404 could misleadingly report a successful creation as failed.
Select directly from the loaded instance list with immediate highlighting, an explicit Selected marker, and aria-pressed. Clear the prior instance's output/file editor/observations on switch while retaining each instance's connection token. Selection stays locked during active operations, with an explanation. Existing server-side access checks remain in place.
Lifecycle event failures are now displayed in the Events panel without undoing selection or completed operations. Event refresh remains explicit after selecting an instance.
Validation: 16 Sandbox tests passed, including selection with no network access, isolation of previous output, busy-state protection, and event 404 handling. Vue script/template compilation and diff checks passed. No live Sandbox mutation was performed.