fix(search): preserve tokenizer migration compatibility - #181
Draft
samzong wants to merge 4 commits into
Draft
Conversation
Signed-off-by: samzong <samzong.lu@gmail.com>
Contributor
Merging this PR will not alter performance
Comparing Footnotes
|
samzong
marked this pull request as draft
August 27, 2026 03:27
Signed-off-by: samzong <samzong.lu@gmail.com>
…atibility Signed-off-by: samzong <samzong.lu@gmail.com>
Signed-off-by: samzong <samzong.lu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Short lexical terms were discarded by the trigram path, and a deferred migration could send trigram grammar to the active unicode61 index. Maintaining two full indexes also caused a real write and search regression. This keeps query grammar aligned with the available index, preserves upgrade and downgrade compatibility, and avoids the steady-state performance cost for new non-CJK messages.
Verification
cargo test -p recall search_keeps_short_mixed_and_deferred_legacy_terms_without_embeddingscargo test -p recall migrate_v12_retries_after_worker_lock_deferralcargo test -p recall init_recreates_missing_trigram_fts_and_reindexes_existing_messagesmake check