PLASMA-7275: update Slider by oki1oki · Pull Request #2835 · salute-developers/plasma

oki1oki · 2026-06-04T10:39:05Z

Core

Slider

добавлено свойство valuePlacement для управления положением value относительно ползунка
исправлена ошибка отображения шкалы прогресса при pointerSize= none

What/why changed

добавлено свойство valuePlacement для управления положением value относительно ползунка
исправлена ошибка отображения шкалы прогресса при pointerSize= none

Before

After

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-asdk@0.378.0-canary.2835.27127573354.0
npm install @salutejs/plasma-b2c@1.620.0-canary.2835.27127573354.0
npm install @salutejs/plasma-core@1.228.0-canary.2835.27127573354.0
npm install @salutejs/plasma-giga@0.347.0-canary.2835.27127573354.0
npm install @salutejs/plasma-homeds@0.347.0-canary.2835.27127573354.0
npm install @salutejs/plasma-hope@1.374.0-canary.2835.27127573354.0
npm install @salutejs/plasma-icons@1.239.0-canary.2835.27127573354.0
npm install @salutejs/plasma-new-hope@0.364.0-canary.2835.27127573354.0
npm install @salutejs/plasma-tokens-b2b@1.56.0-canary.2835.27127573354.0
npm install @salutejs/plasma-tokens-b2c@0.67.0-canary.2835.27127573354.0
npm install @salutejs/plasma-tokens-web@1.71.0-canary.2835.27127573354.0
npm install @salutejs/plasma-tokens@1.140.0-canary.2835.27127573354.0
npm install @salutejs/plasma-typo@0.44.0-canary.2835.27127573354.0
npm install @salutejs/plasma-ui@1.350.0-canary.2835.27127573354.0
npm install @salutejs/plasma-web@1.622.0-canary.2835.27127573354.0
npm install @salutejs/sdds-bizcom@0.352.0-canary.2835.27127573354.0
npm install @salutejs/sdds-cs@0.356.0-canary.2835.27127573354.0
npm install @salutejs/sdds-dfa@0.350.0-canary.2835.27127573354.0
npm install @salutejs/sdds-finai@0.343.0-canary.2835.27127573354.0
npm install @salutejs/sdds-insol@0.347.0-canary.2835.27127573354.0
npm install @salutejs/sdds-netology@0.351.0-canary.2835.27127573354.0
npm install @salutejs/sdds-os@0.22.0-canary.2835.27127573354.0
npm install @salutejs/sdds-platform-ai@0.351.0-canary.2835.27127573354.0
npm install @salutejs/sdds-sbcom@0.352.0-canary.2835.27127573354.0
npm install @salutejs/sdds-scan@0.350.0-canary.2835.27127573354.0
npm install @salutejs/sdds-serv@0.351.0-canary.2835.27127573354.0
npm install @salutejs/core-themes@0.31.0-canary.2835.27127573354.0
npm install @salutejs/plasma-themes@0.52.0-canary.2835.27127573354.0
npm install @salutejs/sdds-themes@0.67.0-canary.2835.27127573354.0
npm install @salutejs/sdds-api-tests@0.9.0-canary.2835.27127573354.0
npm install @salutejs/plasma-cy-utils@0.158.0-canary.2835.27127573354.0
npm install @salutejs/plasma-sb-utils@0.228.0-canary.2835.27127573354.0
npm install @salutejs/plasma-tokens-utils@0.52.0-canary.2835.27127573354.0
# or 
yarn add @salutejs/plasma-asdk@0.378.0-canary.2835.27127573354.0
yarn add @salutejs/plasma-b2c@1.620.0-canary.2835.27127573354.0
yarn add @salutejs/plasma-core@1.228.0-canary.2835.27127573354.0
yarn add @salutejs/plasma-giga@0.347.0-canary.2835.27127573354.0
yarn add @salutejs/plasma-homeds@0.347.0-canary.2835.27127573354.0
yarn add @salutejs/plasma-hope@1.374.0-canary.2835.27127573354.0
yarn add @salutejs/plasma-icons@1.239.0-canary.2835.27127573354.0
yarn add @salutejs/plasma-new-hope@0.364.0-canary.2835.27127573354.0
yarn add @salutejs/plasma-tokens-b2b@1.56.0-canary.2835.27127573354.0
yarn add @salutejs/plasma-tokens-b2c@0.67.0-canary.2835.27127573354.0
yarn add @salutejs/plasma-tokens-web@1.71.0-canary.2835.27127573354.0
yarn add @salutejs/plasma-tokens@1.140.0-canary.2835.27127573354.0
yarn add @salutejs/plasma-typo@0.44.0-canary.2835.27127573354.0
yarn add @salutejs/plasma-ui@1.350.0-canary.2835.27127573354.0
yarn add @salutejs/plasma-web@1.622.0-canary.2835.27127573354.0
yarn add @salutejs/sdds-bizcom@0.352.0-canary.2835.27127573354.0
yarn add @salutejs/sdds-cs@0.356.0-canary.2835.27127573354.0
yarn add @salutejs/sdds-dfa@0.350.0-canary.2835.27127573354.0
yarn add @salutejs/sdds-finai@0.343.0-canary.2835.27127573354.0
yarn add @salutejs/sdds-insol@0.347.0-canary.2835.27127573354.0
yarn add @salutejs/sdds-netology@0.351.0-canary.2835.27127573354.0
yarn add @salutejs/sdds-os@0.22.0-canary.2835.27127573354.0
yarn add @salutejs/sdds-platform-ai@0.351.0-canary.2835.27127573354.0
yarn add @salutejs/sdds-sbcom@0.352.0-canary.2835.27127573354.0
yarn add @salutejs/sdds-scan@0.350.0-canary.2835.27127573354.0
yarn add @salutejs/sdds-serv@0.351.0-canary.2835.27127573354.0
yarn add @salutejs/core-themes@0.31.0-canary.2835.27127573354.0
yarn add @salutejs/plasma-themes@0.52.0-canary.2835.27127573354.0
yarn add @salutejs/sdds-themes@0.67.0-canary.2835.27127573354.0
yarn add @salutejs/sdds-api-tests@0.9.0-canary.2835.27127573354.0
yarn add @salutejs/plasma-cy-utils@0.158.0-canary.2835.27127573354.0
yarn add @salutejs/plasma-sb-utils@0.228.0-canary.2835.27127573354.0
yarn add @salutejs/plasma-tokens-utils@0.52.0-canary.2835.27127573354.0

Summary by CodeRabbit

New Features
- Added pointerSize to control slider thumb appearance: small, large, or hidden (none).
- Added valuePlacement to position the current value alongside the slider (horizontal: top/bottom/none; vertical: left/right/none).
Documentation
- Updated Slider docs with tabbed examples and descriptions for visibility and placement.
Tests
- Added visual snapshot tests covering valuePlacement variations.

coderabbitai · 2026-06-04T10:39:12Z

📝 Walkthrough

Walkthrough

Centralizes slider thumb sizing in a new pointerSize theme variation, implements valuePlacement for current-value rendering, modernizes thumb tokens/styles, updates Slider components/types, and updates stories, tests, and docs across packages.

Changes

Slider Component Enhancements

Layer / File(s)	Summary
Pointer Size Theme Variation Architecture `packages/*/src/components/Slider/Slider.config.ts`, `packages/plasma-new-hope/src/examples/components/Slider/Slider.config.ts`	Adds `defaults.pointerSize: 'small'` and moves thumb sizing/border out of `variations.size` into a new `variations.pointerSize` with `small`/`large`/`none` presets.
Slider Token Contract and Types `packages/plasma-new-hope/src/components/Slider/Slider.tokens.ts`, `packages/plasma-new-hope/src/components/Slider/components/SliderBase/SliderBase.types.ts`, `packages/plasma-new-hope/src/components/Slider/Slider.types.ts`	Extends exported classes with valuePlacement keys, reshapes thumb tokens (adds thumbHeight, thumbBorderStyle/Width/Radius, thumbInnerContent), and adds `pointerSize` typings on base/root props.
Single Slider Value Placement UI and Layout `packages/plasma-new-hope/src/components/Slider/components/Single/*`, `packages/plasma-new-hope/src/components/Slider/utils/getSingleSliderLayout.ts`	Introduces `valuePlacement` prop (orientation-specific), CSS placement classes, layout logic returning `rangeMinValueOpacity`/`rangeMaxValueOpacity` for proximity-based fading; SingleSlider applies placement classes and inline opacity.
SliderBase Thumb Styling Modernization `packages/plasma-new-hope/src/components/Slider/components/SliderBase/*`	Refactors WebKit/Firefox thumb pseudo-element styles to use token-based sizing/border/radius and `thumbInnerContent`, narrows transitions, and removes `privateTokens` usage.
Double Slider Refactoring `packages/plasma-new-hope/src/components/Slider/components/Double/*`	DoubleSlider stops consuming/forwarding `pointerSize`, switches to shared `tokens` for progress math; `DoubleSliderProps` drops `pointerSize`.
Slider Component and Pointer Size Integration `packages/plasma-new-hope/src/components/Slider/Slider.tsx`, `packages/plasma-new-hope/src/components/Slider/variations/_pointer-size/base.tsx`	Imports pointer-size CSS, threads `pointerSize` through sliderRoot (remaps `'none'`→`'small'` for double), wires `pointerSize` into `sliderConfig.variations`, and adds `pointerSize` to root prop types.
Visual Tests and Documentation `packages/plasma-new-hope/src/components/Slider/Slider.component-test.tsx`, `packages/plasma-new-hope/src/components/Slider/Slider.template-doc.mdx`, `website/*/docs/components/Slider.mdx`	Adds Cypress visual snapshot tests for `valuePlacement` (horizontal/vertical) and updates component docs with tabbed "Visibility" and "Placement" examples across brand sites.
Storybook Configuration and Fixtures `utils/plasma-sb-utils/src/components/Slider/fixtures.ts`, `utils/plasma-sb-utils/src/components/Slider/meta.ts`, `utils/plasma-sb-utils/src/components/Slider/stories.tsx`	Adds horizontal/vertical valuePlacement fixtures, a decorator that updates internal visibility flags for placement controls, derives `valuePlacement` in stories, and hides placement controls for multiple-values story variants.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Suggested labels

sdds-sbcom

Suggested reviewers

IgorYar
TitanKuzmich

Poem

🐰 A tiny pointer, sized just so,
Finds its place where values show.
Top or bottom, left or right,
It fades and dances in the light.
Configured clean — hop, code, delight!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'PLASMA-7275: update Slider' is vague and generic, using the non-descriptive term 'update' that doesn't convey meaningful information about the specific changeset.	Consider a more specific title that highlights the main changes, such as 'PLASMA-7275: Add valuePlacement prop and pointerSize fix for Slider' or similar.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch PLASMA-7275

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-06-04T10:53:33Z

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-2835/

github-actions · 2026-06-04T12:31:01Z

Documentation preview deployed!

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

packages/plasma-new-hope/src/components/Slider/Slider.template-doc.mdx (1)

259-299: ⚡ Quick win

Consider adding a vertical slider example in the valuePlacement tab.

The documentation describes vertical slider placement (right, left, none) but only demonstrates horizontal sliders. While the text is accurate and tests cover vertical placement, adding at least one vertical slider example would improve documentation completeness.

📚 Example vertical slider addition

<div style={{ display: 'flex', gap: '2rem', height: '25rem' }}>
    <Slider
        min={0}
        max={100}
        value={v3}
        orientation="vertical"
        showCurrentValue
        valuePlacement="right"
        label="Right (по умолчанию)"
        onChange={setV3}
    />
    <Slider
        min={0}
        max={100}
        value={v4}
        orientation="vertical"
        showCurrentValue
        valuePlacement="left"
        label="Left"
        onChange={setV4}
    />
</div>

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/plasma-new-hope/src/components/Slider/Slider.template-doc.mdx`
around lines 259 - 299, Add a vertical slider example to the "valuePlacement"
TabItem: introduce two new state vars (e.g., v3/v4 with setV3/setV4) and render
a vertical container showing two Slider components with orientation="vertical",
showCurrentValue, valuePlacement="right" and valuePlacement="left" respectively,
supplying min/max/value/label/onChange; ensure the container uses a fixed height
(instead of width) to display vertical sliders correctly and mirror the existing
horizontal examples' props and structure.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@packages/plasma-new-hope/src/components/Slider/utils/getSingleSliderLayout.ts`:
- Around line 126-127: The opacity calculation for range labels
(rangeMaxValueOpacity and rangeMinValueOpacity) currently gates fading only on
innerShowCurrentValue, so min/max labels still fade even when valuePlacement is
"none"; update both conditions to require the current value to actually be
visible (e.g., innerShowCurrentValue && valuePlacement !== "none" or the
existing boolean that represents placement visibility) before calling
fadeOpacity with the reversed/thumbPercent logic (keep thumbPercent and reversed
usage unchanged).

---

Nitpick comments:
In `@packages/plasma-new-hope/src/components/Slider/Slider.template-doc.mdx`:
- Around line 259-299: Add a vertical slider example to the "valuePlacement"
TabItem: introduce two new state vars (e.g., v3/v4 with setV3/setV4) and render
a vertical container showing two Slider components with orientation="vertical",
showCurrentValue, valuePlacement="right" and valuePlacement="left" respectively,
supplying min/max/value/label/onChange; ensure the container uses a fixed height
(instead of width) to display vertical sliders correctly and mirror the existing
horizontal examples' props and structure.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 32ac3ece-fbb3-49de-a811-f88e2b87a024

📥 Commits

Reviewing files that changed from the base of the PR and between fcc43fb and 20d2e8a.

⛔ Files ignored due to path filters (89)

cypress/snapshots/b2c/chromium/Slider/Slider -- orientation, reversed, sliderTicks.snap.png is excluded by !**/*.png
cypress/snapshots/b2c/chromium/Slider/Slider -- valuePlacement, horizontal.snap.png is excluded by !**/*.png
cypress/snapshots/b2c/chromium/Slider/Slider -- valuePlacement, vertical.snap.png is excluded by !**/*.png
cypress/snapshots/b2c/webkit/Slider/Slider -- orientation, reversed, sliderTicks.snap.png is excluded by !**/*.png
cypress/snapshots/b2c/webkit/Slider/Slider -- valuePlacement, horizontal.snap.png is excluded by !**/*.png
cypress/snapshots/b2c/webkit/Slider/Slider -- valuePlacement, vertical.snap.png is excluded by !**/*.png
cypress/snapshots/cs/chromium/Slider/Slider -- focus.snap.png is excluded by !**/*.png
cypress/snapshots/cs/chromium/Slider/Slider -- orientation, reversed, sliderTicks.snap.png is excluded by !**/*.png
cypress/snapshots/cs/chromium/Slider/Slider -- valuePlacement, horizontal.snap.png is excluded by !**/*.png
cypress/snapshots/cs/chromium/Slider/Slider -- valuePlacement, vertical.snap.png is excluded by !**/*.png
cypress/snapshots/cs/webkit/Slider/Slider -- focus.snap.png is excluded by !**/*.png
cypress/snapshots/cs/webkit/Slider/Slider -- orientation, reversed, sliderTicks.snap.png is excluded by !**/*.png
cypress/snapshots/cs/webkit/Slider/Slider -- valuePlacement, horizontal.snap.png is excluded by !**/*.png
cypress/snapshots/cs/webkit/Slider/Slider -- valuePlacement, vertical.snap.png is excluded by !**/*.png
cypress/snapshots/finai/chromium/Slider/Slider -- focus.snap.png is excluded by !**/*.png
cypress/snapshots/finai/chromium/Slider/Slider -- orientation, reversed, sliderTicks.snap.png is excluded by !**/*.png
cypress/snapshots/finai/chromium/Slider/Slider -- valuePlacement, horizontal.snap.png is excluded by !**/*.png
cypress/snapshots/finai/chromium/Slider/Slider -- valuePlacement, vertical.snap.png is excluded by !**/*.png
cypress/snapshots/finai/webkit/Slider/Slider -- focus.snap.png is excluded by !**/*.png
cypress/snapshots/finai/webkit/Slider/Slider -- orientation, reversed, sliderTicks.snap.png is excluded by !**/*.png
cypress/snapshots/finai/webkit/Slider/Slider -- valuePlacement, horizontal.snap.png is excluded by !**/*.png
cypress/snapshots/finai/webkit/Slider/Slider -- valuePlacement, vertical.snap.png is excluded by !**/*.png
cypress/snapshots/giga/chromium/Slider/Slider -- focus.snap.png is excluded by !**/*.png
cypress/snapshots/giga/chromium/Slider/Slider -- orientation, reversed, sliderTicks.snap.png is excluded by !**/*.png
cypress/snapshots/giga/chromium/Slider/Slider -- valuePlacement, horizontal.snap.png is excluded by !**/*.png
cypress/snapshots/giga/chromium/Slider/Slider -- valuePlacement, vertical.snap.png is excluded by !**/*.png
cypress/snapshots/giga/webkit/Slider/Slider -- focus.snap.png is excluded by !**/*.png
cypress/snapshots/giga/webkit/Slider/Slider -- orientation, reversed, sliderTicks.snap.png is excluded by !**/*.png
cypress/snapshots/giga/webkit/Slider/Slider -- valuePlacement, horizontal.snap.png is excluded by !**/*.png
cypress/snapshots/giga/webkit/Slider/Slider -- valuePlacement, vertical.snap.png is excluded by !**/*.png
cypress/snapshots/homeds/chromium/Slider/Slider -- focus.snap.png is excluded by !**/*.png
cypress/snapshots/homeds/chromium/Slider/Slider -- orientation, reversed, sliderTicks.snap.png is excluded by !**/*.png
cypress/snapshots/homeds/chromium/Slider/Slider -- valuePlacement, horizontal.snap.png is excluded by !**/*.png
cypress/snapshots/homeds/chromium/Slider/Slider -- valuePlacement, vertical.snap.png is excluded by !**/*.png
cypress/snapshots/homeds/webkit/Slider/Slider -- focus.snap.png is excluded by !**/*.png
cypress/snapshots/homeds/webkit/Slider/Slider -- orientation, reversed, sliderTicks.snap.png is excluded by !**/*.png
cypress/snapshots/homeds/webkit/Slider/Slider -- valuePlacement, horizontal.snap.png is excluded by !**/*.png
cypress/snapshots/homeds/webkit/Slider/Slider -- valuePlacement, vertical.snap.png is excluded by !**/*.png
cypress/snapshots/insol/chromium/Slider/Slider -- disabled.snap.png is excluded by !**/*.png
cypress/snapshots/insol/chromium/Slider/Slider -- orientation, labelPlacement.snap.png is excluded by !**/*.png
cypress/snapshots/insol/chromium/Slider/Slider -- orientation, reversed, sliderTicks.snap.png is excluded by !**/*.png
cypress/snapshots/insol/chromium/Slider/Slider -- orientation, sliderAlign, showScale.snap.png is excluded by !**/*.png
cypress/snapshots/insol/chromium/Slider/Slider -- pointerSize.snap.png is excluded by !**/*.png
cypress/snapshots/insol/chromium/Slider/Slider -- pointerVisibility.snap.png is excluded by !**/*.png
cypress/snapshots/insol/chromium/Slider/Slider -- showCurrentValue, hideMinValueDiff, hideMaxValueDiff.snap.png is excluded by !**/*.png
cypress/snapshots/insol/chromium/Slider/Slider -- simple.snap.png is excluded by !**/*.png
cypress/snapshots/insol/chromium/Slider/Slider -- step, clampedValue.snap.png is excluded by !**/*.png
cypress/snapshots/insol/chromium/Slider/Slider -- valuePlacement, horizontal.snap.png is excluded by !**/*.png
cypress/snapshots/insol/chromium/Slider/Slider -- valuePlacement, vertical.snap.png is excluded by !**/*.png
cypress/snapshots/insol/chromium/Slider/Slider -- view=accent, size=m.snap.png is excluded by !**/*.png
cypress/snapshots/insol/chromium/Slider/Slider -- view=default, size=l.snap.png is excluded by !**/*.png
cypress/snapshots/insol/chromium/Slider/before-hover.snap.png is excluded by !**/*.png
cypress/snapshots/insol/webkit/Slider/Slider -- disabled.snap.png is excluded by !**/*.png
cypress/snapshots/insol/webkit/Slider/Slider -- focus.snap.png is excluded by !**/*.png
cypress/snapshots/insol/webkit/Slider/Slider -- orientation, labelPlacement.snap.png is excluded by !**/*.png
cypress/snapshots/insol/webkit/Slider/Slider -- orientation, reversed, sliderTicks.snap.png is excluded by !**/*.png
cypress/snapshots/insol/webkit/Slider/Slider -- orientation, sliderAlign, showScale.snap.png is excluded by !**/*.png
cypress/snapshots/insol/webkit/Slider/Slider -- pointerSize.snap.png is excluded by !**/*.png
cypress/snapshots/insol/webkit/Slider/Slider -- pointerVisibility.snap.png is excluded by !**/*.png
cypress/snapshots/insol/webkit/Slider/Slider -- showCurrentValue, hideMinValueDiff, hideMaxValueDiff.snap.png is excluded by !**/*.png
cypress/snapshots/insol/webkit/Slider/Slider -- simple.snap.png is excluded by !**/*.png
cypress/snapshots/insol/webkit/Slider/Slider -- step, clampedValue.snap.png is excluded by !**/*.png
cypress/snapshots/insol/webkit/Slider/Slider -- valuePlacement, horizontal.snap.png is excluded by !**/*.png
cypress/snapshots/insol/webkit/Slider/Slider -- valuePlacement, vertical.snap.png is excluded by !**/*.png
cypress/snapshots/insol/webkit/Slider/Slider -- view=accent, size=m.snap.png is excluded by !**/*.png
cypress/snapshots/insol/webkit/Slider/Slider -- view=default, size=l.snap.png is excluded by !**/*.png
cypress/snapshots/insol/webkit/Slider/before-hover.snap.png is excluded by !**/*.png
cypress/snapshots/platform-ai/chromium/Slider/Slider -- orientation, reversed, sliderTicks.snap.png is excluded by !**/*.png
cypress/snapshots/platform-ai/chromium/Slider/Slider -- valuePlacement, horizontal.snap.png is excluded by !**/*.png
cypress/snapshots/platform-ai/chromium/Slider/Slider -- valuePlacement, vertical.snap.png is excluded by !**/*.png
cypress/snapshots/platform-ai/webkit/Slider/Slider -- focus.snap.png is excluded by !**/*.png
cypress/snapshots/platform-ai/webkit/Slider/Slider -- orientation, reversed, sliderTicks.snap.png is excluded by !**/*.png
cypress/snapshots/platform-ai/webkit/Slider/Slider -- valuePlacement, horizontal.snap.png is excluded by !**/*.png
cypress/snapshots/platform-ai/webkit/Slider/Slider -- valuePlacement, vertical.snap.png is excluded by !**/*.png
cypress/snapshots/serv/chromium/Slider/Slider -- focus.snap.png is excluded by !**/*.png
cypress/snapshots/serv/chromium/Slider/Slider -- orientation, reversed, sliderTicks.snap.png is excluded by !**/*.png
cypress/snapshots/serv/chromium/Slider/Slider -- valuePlacement, horizontal.snap.png is excluded by !**/*.png
cypress/snapshots/serv/chromium/Slider/Slider -- valuePlacement, vertical.snap.png is excluded by !**/*.png
cypress/snapshots/serv/webkit/Slider/Slider -- focus.snap.png is excluded by !**/*.png
cypress/snapshots/serv/webkit/Slider/Slider -- orientation, reversed, sliderTicks.snap.png is excluded by !**/*.png
cypress/snapshots/serv/webkit/Slider/Slider -- valuePlacement, horizontal.snap.png is excluded by !**/*.png
cypress/snapshots/serv/webkit/Slider/Slider -- valuePlacement, vertical.snap.png is excluded by !**/*.png
cypress/snapshots/web/chromium/Slider/Slider -- focus.snap.png is excluded by !**/*.png
cypress/snapshots/web/chromium/Slider/Slider -- orientation, reversed, sliderTicks.snap.png is excluded by !**/*.png
cypress/snapshots/web/chromium/Slider/Slider -- valuePlacement, horizontal.snap.png is excluded by !**/*.png
cypress/snapshots/web/chromium/Slider/Slider -- valuePlacement, vertical.snap.png is excluded by !**/*.png
cypress/snapshots/web/webkit/Slider/Slider -- orientation, reversed, sliderTicks.snap.png is excluded by !**/*.png
cypress/snapshots/web/webkit/Slider/Slider -- valuePlacement, horizontal.snap.png is excluded by !**/*.png
cypress/snapshots/web/webkit/Slider/Slider -- valuePlacement, vertical.snap.png is excluded by !**/*.png

📒 Files selected for processing (43)

packages/plasma-b2c/src/components/Slider/Slider.config.ts
packages/plasma-giga/src/components/Slider/Slider.config.ts
packages/plasma-homeds/src/components/Slider/Slider.config.ts
packages/plasma-new-hope/src/components/Slider/Slider.component-test.tsx
packages/plasma-new-hope/src/components/Slider/Slider.template-doc.mdx
packages/plasma-new-hope/src/components/Slider/Slider.tokens.ts
packages/plasma-new-hope/src/components/Slider/Slider.tsx
packages/plasma-new-hope/src/components/Slider/Slider.types.ts
packages/plasma-new-hope/src/components/Slider/components/Double/Double.tsx
packages/plasma-new-hope/src/components/Slider/components/Double/Double.types.ts
packages/plasma-new-hope/src/components/Slider/components/Single/Single.styles.ts
packages/plasma-new-hope/src/components/Slider/components/Single/Single.tsx
packages/plasma-new-hope/src/components/Slider/components/Single/Single.types.ts
packages/plasma-new-hope/src/components/Slider/components/SliderBase/SliderBase.styles.ts
packages/plasma-new-hope/src/components/Slider/components/SliderBase/SliderBase.types.ts
packages/plasma-new-hope/src/components/Slider/utils/getSingleSliderLayout.ts
packages/plasma-new-hope/src/components/Slider/variations/_pointer-size/base.tsx
packages/plasma-new-hope/src/components/Slider/variations/_pointer-size/tokens.json
packages/plasma-new-hope/src/examples/components/Slider/Slider.config.ts
packages/plasma-web/src/components/Slider/Slider.config.ts
packages/sdds-bizcom/src/components/Slider/Slider.config.ts
packages/sdds-cs/src/components/Slider/Slider.config.ts
packages/sdds-dfa/src/components/Slider/Slider.config.ts
packages/sdds-finai/src/components/Slider/Slider.config.ts
packages/sdds-insol/src/components/Slider/Slider.config.ts
packages/sdds-netology/src/components/Slider/Slider.config.ts
packages/sdds-platform-ai/src/components/Slider/Slider.config.ts
packages/sdds-sbcom/src/components/Slider/Slider.config.ts
packages/sdds-scan/src/components/Slider/Slider.config.ts
packages/sdds-serv/src/components/Slider/Slider.config.ts
utils/plasma-sb-utils/src/components/Slider/fixtures.ts
utils/plasma-sb-utils/src/components/Slider/meta.ts
utils/plasma-sb-utils/src/components/Slider/stories.tsx
website/plasma-b2c-docs/docs/components/Slider.mdx
website/plasma-giga-docs/docs/components/Slider.mdx
website/plasma-homeds-docs/docs/components/Slider.mdx
website/plasma-web-docs/docs/components/Slider.mdx
website/sdds-dfa-docs/docs/components/Slider.mdx
website/sdds-finai-docs/docs/components/Slider.mdx
website/sdds-insol-docs/docs/components/Slider.mdx
website/sdds-netology-docs/docs/components/Slider.mdx
website/sdds-platform-ai-docs/docs/components/Slider.mdx
website/sdds-serv-docs/docs/components/Slider.mdx

💤 Files with no reviewable changes (1)

packages/plasma-new-hope/src/components/Slider/components/Double/Double.types.ts

IgorYar

Нет доки для Slider в sdds-scan.
В доке sdds-bizcom и sdds-cs очень мало примеров по сравнению с остальными либами. Можем сделать единообразно в этом пр?
https://plasma.sberdevices.ru/pr/pr-2835/sdds-cs/components/slider/

oki1oki self-assigned this Jun 4, 2026

oki1oki temporarily deployed to internal June 4, 2026 10:39 — with GitHub Actions Inactive

Yakutoc reviewed Jun 4, 2026

View reviewed changes

Comment thread cypress/snapshots/insol/chromium/Slider/Slider -- focus.snap.png

oki1oki force-pushed the PLASMA-7275 branch from b73b969 to e931221 Compare June 4, 2026 16:12

oki1oki temporarily deployed to internal June 4, 2026 16:12 — with GitHub Actions Inactive

oki1oki force-pushed the PLASMA-7275 branch from e931221 to 20d2e8a Compare June 4, 2026 16:22

oki1oki temporarily deployed to internal June 4, 2026 16:23 — with GitHub Actions Inactive

oki1oki marked this pull request as ready for review June 4, 2026 18:44

oki1oki requested review from TitanKuzmich, Yeti-or, neretin-trike and shuga2704 as code owners June 4, 2026 18:44

oki1oki requested review from IgorYar and removed request for Yeti-or, neretin-trike and shuga2704 June 4, 2026 18:45

coderabbitai Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread packages/plasma-new-hope/src/components/Slider/utils/getSingleSliderLayout.ts Outdated

oki1oki force-pushed the PLASMA-7275 branch from 20d2e8a to 37edfe0 Compare June 4, 2026 21:50

oki1oki temporarily deployed to internal June 4, 2026 21:50 — with GitHub Actions Inactive

oki1oki temporarily deployed to internal June 4, 2026 22:25 — with GitHub Actions Inactive

IgorYar reviewed Jun 5, 2026

View reviewed changes

oki1oki force-pushed the PLASMA-7275 branch from a43831d to 8e5f96c Compare June 5, 2026 14:07

oki1oki temporarily deployed to internal June 5, 2026 14:07 — with GitHub Actions Inactive

TitanKuzmich reviewed Jun 8, 2026

View reviewed changes

Comment thread packages/plasma-new-hope/src/components/Slider/components/SliderBase/SliderBase.types.ts

TitanKuzmich approved these changes Jun 8, 2026

View reviewed changes

oki1oki force-pushed the PLASMA-7275 branch from 8e5f96c to 7eb8ba0 Compare June 8, 2026 07:48

oki1oki temporarily deployed to internal June 8, 2026 07:48 — with GitHub Actions Inactive

oki1oki force-pushed the PLASMA-7275 branch from 7eb8ba0 to ba9ea2a Compare June 8, 2026 08:37

oki1oki temporarily deployed to internal June 8, 2026 08:37 — with GitHub Actions Inactive

oki1oki added 3 commits June 8, 2026 12:12

feat(): update Slider [PLASMA-7275]

7e41ce0

docs(): update Slider

a60c9be

test(): update Slider tests [PLASMA-7275]

555b5d4

oki1oki force-pushed the PLASMA-7275 branch from ba9ea2a to 555b5d4 Compare June 8, 2026 09:12

oki1oki temporarily deployed to internal June 8, 2026 09:12 — with GitHub Actions Inactive

oki1oki temporarily deployed to internal June 8, 2026 09:17 — with GitHub Actions Inactive

IgorYar approved these changes Jun 8, 2026

View reviewed changes

oki1oki added this pull request to the merge queue Jun 8, 2026

Merged via the queue into dev with commit 487961e Jun 8, 2026
60 checks passed

oki1oki deleted the PLASMA-7275 branch June 8, 2026 10:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PLASMA-7275: update Slider#2835

PLASMA-7275: update Slider#2835
oki1oki merged 3 commits into
devfrom
PLASMA-7275

oki1oki commented Jun 4, 2026 •

edited by Salute-Eva

Loading

Uh oh!

coderabbitai Bot commented Jun 4, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested labels

Suggested reviewers

Poem

❌ Failed checks (1 inconclusive)

Uh oh!

Uh oh!

github-actions Bot commented Jun 4, 2026

Uh oh!

github-actions Bot commented Jun 4, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

IgorYar left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

oki1oki commented Jun 4, 2026 • edited by Salute-Eva Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Core

Slider

What/why changed

Before

After

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

Suggested reviewers

Poem

❌ Failed checks (1 inconclusive)

Uh oh!

Uh oh!

github-actions Bot commented Jun 4, 2026

Uh oh!

github-actions Bot commented Jun 4, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

IgorYar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oki1oki commented Jun 4, 2026 •

edited by Salute-Eva

Loading

coderabbitai Bot commented Jun 4, 2026 •

edited

Loading