PLASMA-7225: Motion Api was added in RadioBox, Switch, CheckBox#792
Open
SerraMorec wants to merge 4 commits into
Open
PLASMA-7225: Motion Api was added in RadioBox, Switch, CheckBox#792SerraMorec wants to merge 4 commits into
SerraMorec wants to merge 4 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
Collaborator
📦 Собранные Debug APK
📲 Как установить APK на Android-устройство:
💻 Установка через USB (ADB):
|
malilex
reviewed
Jun 1, 2026
malilex
reviewed
Jun 1, 2026
malilex
reviewed
Jun 1, 2026
malilex
reviewed
Jun 1, 2026
malilex
reviewed
Jun 1, 2026
malilex
reviewed
Jun 1, 2026
malilex
reviewed
Jun 1, 2026
malilex
requested changes
Jun 1, 2026
803f2e2 to
17b7273
Compare
malilex
reviewed
Jun 2, 2026
| ) { | ||
| SideEffect { | ||
| motion.context.semanticStateSource.clear() | ||
| motion.context.semanticStateSource.remove() |
Collaborator
There was a problem hiding this comment.
пустой remove ничего не удаляет.
нужно передавать параметры
25eda4b to
67aeaa1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sdds-uikit-compose
Switch
RadioBox
CheckBox
What/why changed
Для компонентов Switch, CheckBox и RadioBox добавлены Motion и MotionStyle, с помощью которых можно настроить анимацию изменения параметров цвета и типографики. Стили переведены на StatefulValue. Для корректной работы анимаций RadioBox с помощью Motion Api в конфигурацию и стили добавлены дефолтные значение размера toggleIcon