Repository URL in pillar

[SndR85]

No description provided.

[wwentland]

I like your commit, but could you translate your commit message to English? As a native German speaker I can read it, but other people might not be so furtunate :)

[SndR85]

I have changed my commit. I also updated the example.pillar.

[wwentland]

Thank you for your changes! One thing met my eye, though.

Where do you set the defaults for logstash_forwarder.repo.gpgurl and logstash_forwarder.repo.url ? It looks as if users would have to set it in their pillar in order to keep using the state.

It would be nice if users were given the ability to override those values in, for example, logstash_forwarder:lookup:repo_url and logstash_forwarder:lookup:repo_key_url (with a lookup for logstash_forwarder:repo_url and logstash_formwarder:repo_key_url in the state). You might therefore like to set these in the map.jinja file.

Furthermore this change might make sense for both Debian and RedHat type repositories.

Thanks a lot for your effort, much appreciated!

[SndR85]

You're right. I did set the defaults in map.jinja. Also I added gpgname to be variable.

[wwentland]

This is indented differently unfortunately :(

[SndR85]

Actually, it's an added comma.

[wwentland]

Cool, thank you.. I found two other things (see my comments) of which I am not sure if they constitute a problem or not.

I'll look at this later.