refactor: devScripts update @W-23474629@

eslint.config.mjs

@@ -0,0 +1 @@
+export { default } from 'eslint-config-salesforce-typescript';

package.json

@@ -23,19 +23,21 @@
   "devDependencies": {
     "@oclif/plugin-command-snapshot": "^5.3.34",
     "@salesforce/cli-plugins-testkit": "^5.3.64",
-    "@salesforce/dev-scripts": "^11.0.4",
+    "@salesforce/dev-scripts": "^13.0.1",
     "@salesforce/plugin-command-reference": "^3.1.125",
     "@salesforce/ts-sinon": "^1.4.36",
     "@salesforce/ts-types": "^3.0.1",
     "@types/marked": "^4.0.8",
     "@types/marked-terminal": "^3.1.3",
     "@types/semver": "^7.8.0",
     "@types/sinon-chai": "^3.2.12",
+    "eslint": "^10.4.0",
+    "eslint-config-salesforce-typescript": "^6.0.0",
     "eslint-plugin-sf-plugin": "^1.20.33",
     "oclif": "^4.23.29",
     "sinon-chai": "^3.7.0",
     "ts-node": "^10.9.2",
-    "typescript": "^5.5.4"
+    "typescript": "^5.5.4 || ^6"
   },
   "resolutions": {
     "@jsforce/jsforce-node/node-fetch/whatwg-url": "^14.0.0"
@@ -146,6 +148,7 @@
         "src/**/*.ts",
         "test/**/*.ts",
         "messages/**",
+        "**/eslint.config.*",
         "**/.eslint*",
         "**/tsconfig.json"
       ],

src/diagnostics.ts

@@ -146,7 +146,7 @@ export class Diagnostics {
           const conn = new Connection();
           await conn.request(url);
           await Lifecycle.getInstance().emit('Doctor:diagnostic', { testName: `can access: ${url}`, status: 'pass' });
-        } catch (e) {
+        } catch {
           await Lifecycle.getInstance().emit('Doctor:diagnostic', { testName: `can't access: ${url}`, status: 'fail' });
           this.doctor.addSuggestion(
             `Cannot reach ${url} - potential network configuration error, check proxies, firewalls, environment variables`
@@ -163,7 +163,7 @@ export class Diagnostics {
         testName: `can access: ${manifestUrl}`,
         status: 'pass',
       });
-    } catch (e) {
+    } catch {
       await Lifecycle.getInstance().emit('Doctor:diagnostic', {
         testName: `can't access: ${manifestUrl}`,
         status: 'fail',

test/commands/doctor.test.ts

@@ -153,7 +153,7 @@
     return cmd.run();
   };
 
   beforeEach(async () => {
     fsExistsSyncStub = stubMethod(sandbox, fs, 'existsSync');
     fsMkdirSyncStub = stubMethod(sandbox, fs, 'mkdirSync');
     fsWriteFileSyncStub = stubMethod(sandbox, fs, 'writeFileSync');
@@ -167,10 +167,10 @@
     stubMethod(sandbox, Doctor.prototype, 'closeStderr');
   });
 
   afterEach(() => {
     sandbox.restore();
     // Reset the instance for testing
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment,@typescript-eslint/no-unsafe-assignment
+    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-ignore
     delete Doctor.instance;
   });
@@ -213,7 +213,7 @@
     });
   };
 
   it('runs doctor command with no flags', async () => {
     const suggestion = 'work smarter, not faster';
     fsExistsSyncStub.returns(true);
     const diagnosticStatus = { testName: 'doctor test', status: 'pass' };
@@ -248,7 +248,7 @@
     ]);
   });
 
   it('reports on uppercase and lowercase proxy env vars', async () => {
     const httpProxyEnv = ['http_proxy', 'test.http.proxy'];
     const httpsProxyEnv = ['HTTPS_PROXY', 'test.HTTPS.proxy'];
     const noProxyEnv = ['no_proxy', 'test.blah.com'];
@@ -276,7 +276,7 @@
     }
   });
 
   it('runs doctor command with outputdir flag (existing dir)', async () => {
     const outputdir = path.resolve('foo', 'bar', 'test');
     fsExistsSyncStub.returns(true);
     Doctor.init(oclifConfig);
@@ -305,7 +305,7 @@
     ]);
   });
 
   it('runs doctor command with outputdir flag (non-existing dir)', async () => {
     const outputdir = path.resolve('foo', 'bar', 'test');
     fsExistsSyncStub.returns(false);
     Doctor.init(oclifConfig);
@@ -334,7 +334,7 @@
     ]);
   });
 
   it('runs doctor command with command flag (minimal)', async () => {
     const cmd = 'force:org:list --all';
     const expectedCmd = `${oclifConfig.bin} ${cmd} --dev-debug`;
     fsExistsSyncStub.returns(true);
@@ -369,7 +369,7 @@
     expect(result).to.have.property('commandName', expectedCmd);
   });
 
   it('runs doctor command with command flag (full)', async () => {
     const cmd = `${oclifConfig.bin} force:org:list --all --dev-debug`;
     fsExistsSyncStub.returns(true);
     Doctor.init(oclifConfig);
@@ -404,7 +404,7 @@
     expect(result).to.have.property('commandName', cmd);
   });
 
   it('runs doctor command with plugin flag', async () => {
     fsExistsSyncStub.returns(true);
     Doctor.init(oclifConfig);
     diagnosticsRunStub.callsFake(() => [Promise.resolve()]);
@@ -429,7 +429,7 @@
     expect(runHookStub.args).to.deep.equal([['sf-doctor-@salesforce/plugin-org']]);
   });
 
   it('runs doctor command with plugin flag (no plugin tests)', async () => {
     fsExistsSyncStub.returns(true);
     const versionDetail = getVersionDetailStub();
     // @ts-expect-error: stubbing a private property

test/diagnostics.test.ts

@@ -86,7 +86,7 @@ describe('Diagnostics', () => {
   afterEach(() => {
     sandbox.restore();
     // Reset the instance for testing
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment,@typescript-eslint/no-unsafe-assignment
+    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-ignore
     delete Doctor.instance;
   });

test/doctor.test.ts

@@ -71,7 +71,7 @@ describe('Doctor Class', () => {
   afterEach(() => {
     sandbox.restore();
     // Reset the instance for testing
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment,@typescript-eslint/no-unsafe-assignment
+    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-ignore
     delete Doctor.instance;
   });

test/shared/getInfoConfig.test.ts

@@ -48,7 +48,7 @@ describe('getInfoConfig tests', () => {
           },
         },
       },
-    } as PjsonWithInfo;
+    };
 
     // keep pjsonMock as JSON to access values in tests
     readFileStub = stubMethod(sandbox, fs.promises, 'readFile').resolves(JSON.stringify(pjsonMock));