fix: preserve labels when loading CSV adjacency matrices - #69
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a CSV saved with
graph.to_csv(path)toBayesianNetwork,HT, orRandomWalkcurrently treats the row-label column as adjacency data. BayesianNetwork then compares string labels with zero, while the NetworkX-based analyzers cannot match the generated integer index to the metric columns.Share a CSV loader that restores the first column as row labels when present. Square CSV files written with
index=Falseremain supported, with rows following the metric-column order. The configuration docstrings now explain both formats.Validation: all 12 analyzer tests pass, with two existing tests skipped. Six indexed-CSV regressions fail before the fix; three additional cases cover index-free CSV compatibility. Tests verify the loaded matrices, node names, and directed edges for all three analyzers. Required Black and license-header hooks pass. Tested on Python 3.10 with NumPy 1.23.5, pandas 1.5.3, and scikit-learn 1.1.3.