Skip to content

Merge release/3.1.0 into development - #168

Merged
webianks merged 3 commits into
developmentfrom
release/3.1.0
Jul 30, 2026
Merged

Merge release/3.1.0 into development#168
webianks merged 3 commits into
developmentfrom
release/3.1.0

Conversation

@webianks

Copy link
Copy Markdown
Collaborator

This pull request introduces several important updates to the project, focusing on build system modernization, improved type safety in database converters, and enhanced back navigation handling in the UI. The changes also include dependency upgrades and version bumps to keep the project up-to-date.

Build System and Dependency Updates:

  • Migrated annotation processing from kapt to ksp for both Room and Hilt, and updated Hilt dependencies to version 2.60.1. Also updated Gradle from 9.1.0 to 9.6.1 and enabled parallel sync for improved build performance. [1] [2] [3] [4]

Database Type Safety Improvements:

  • Refactored all Room TypeConverter methods in Converters.kt to use non-nullable ArrayList types, add null/empty checks, and remove unnecessary nullability, improving type safety and preventing potential crashes.

UI/UX Enhancements:

  • Replaced deprecated onBackPressed overrides in both MainActivity and CastCrewDetailsActivity with the modern onBackPressedDispatcher.addCallback approach, ensuring proper back navigation and fragment dismissal behavior. [1] [2] [3] [4]

Version and Target Updates:

  • Bumped targetSdkVersion to 36, incremented versionCode to 24, and updated versionName to 3.1.0 in both build.gradle and preference.xml to reflect the new release. [1] [2]

Cleanup and Modernization:

  • Removed obsolete kotlinOptions and kapt blocks from build.gradle, aligning with the migration to ksp.

These changes collectively improve the codebase's maintainability, safety, and user experience.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR merges the release/3.1.0 branch into development, primarily modernizing the Android build setup (Gradle/AGP + KSP migration), tightening Room converter type-safety for several list fields, and updating back-navigation handling in key activities while bumping app version metadata.

Changes:

  • Upgrades Gradle/AGP/Hilt and migrates annotation processing from kapt to ksp, plus enables parallel tooling sync.
  • Refactors multiple Room TypeConverters to return non-null lists with null/empty handling.
  • Replaces deprecated onBackPressed() overrides with onBackPressedDispatcher.addCallback, and bumps app version/target SDK.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
gradle/wrapper/gradle-wrapper.properties Updates Gradle wrapper distribution version.
gradle.properties Enables Gradle tooling parallel sync and adjusts Gradle JVM args config.
build.gradle Updates AGP/Hilt and adds KSP plugin declaration at the root level.
app/build.gradle Migrates Room/Hilt processors to KSP and bumps targetSdk/version; removes kapt and Kotlin Android plugin application.
app/src/main/res/xml/preference.xml Updates displayed app version string to 3.1.0.
app/src/main/java/tech/salroid/filmy/ui/home/MainActivity.kt Migrates back handling to OnBackPressedDispatcher with search-close behavior.
app/src/main/java/tech/salroid/filmy/ui/cast_crew/CastCrewDetailsActivity.kt Migrates back handling to OnBackPressedDispatcher to dismiss the description fragment first.
app/src/main/java/tech/salroid/filmy/data/local/db/Converters.kt Makes several list converters non-nullable and adds null/empty handling.
Comments suppressed due to low confidence (2)

app/src/main/java/tech/salroid/filmy/data/local/db/Converters.kt:70

  • Parameter name genres is misleading here; it actually contains production countries. This makes the converter harder to read and maintain.
    fun fromArrayListOfProductionCountries(genres: ArrayList<ProductionCountries>): String {
        return Gson().toJson(genres)

app/src/main/java/tech/salroid/filmy/data/local/db/Converters.kt:82

  • Parameter name genres is misleading here; it actually contains spoken languages. This makes the converter harder to read and maintain.
    fun fromArrayListOfSpokenLanguages(genres: ArrayList<SpokenLanguages>): String {
        return Gson().toJson(genres)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/build.gradle
Comment thread app/src/main/java/tech/salroid/filmy/data/local/db/Converters.kt
@webianks
webianks merged commit 69115b5 into development Jul 30, 2026
1 check passed
@webianks
webianks deleted the release/3.1.0 branch August 1, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants