Merge release/3.1.0 into development - #168
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR merges the release/3.1.0 branch into development, primarily modernizing the Android build setup (Gradle/AGP + KSP migration), tightening Room converter type-safety for several list fields, and updating back-navigation handling in key activities while bumping app version metadata.
Changes:
- Upgrades Gradle/AGP/Hilt and migrates annotation processing from
kapttoksp, plus enables parallel tooling sync. - Refactors multiple Room
TypeConverters to return non-null lists with null/empty handling. - Replaces deprecated
onBackPressed()overrides withonBackPressedDispatcher.addCallback, and bumps app version/target SDK.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper distribution version. |
| gradle.properties | Enables Gradle tooling parallel sync and adjusts Gradle JVM args config. |
| build.gradle | Updates AGP/Hilt and adds KSP plugin declaration at the root level. |
| app/build.gradle | Migrates Room/Hilt processors to KSP and bumps targetSdk/version; removes kapt and Kotlin Android plugin application. |
| app/src/main/res/xml/preference.xml | Updates displayed app version string to 3.1.0. |
| app/src/main/java/tech/salroid/filmy/ui/home/MainActivity.kt | Migrates back handling to OnBackPressedDispatcher with search-close behavior. |
| app/src/main/java/tech/salroid/filmy/ui/cast_crew/CastCrewDetailsActivity.kt | Migrates back handling to OnBackPressedDispatcher to dismiss the description fragment first. |
| app/src/main/java/tech/salroid/filmy/data/local/db/Converters.kt | Makes several list converters non-nullable and adds null/empty handling. |
Comments suppressed due to low confidence (2)
app/src/main/java/tech/salroid/filmy/data/local/db/Converters.kt:70
- Parameter name
genresis misleading here; it actually contains production countries. This makes the converter harder to read and maintain.
fun fromArrayListOfProductionCountries(genres: ArrayList<ProductionCountries>): String {
return Gson().toJson(genres)
app/src/main/java/tech/salroid/filmy/data/local/db/Converters.kt:82
- Parameter name
genresis misleading here; it actually contains spoken languages. This makes the converter harder to read and maintain.
fun fromArrayListOfSpokenLanguages(genres: ArrayList<SpokenLanguages>): String {
return Gson().toJson(genres)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
salRoid
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several important updates to the project, focusing on build system modernization, improved type safety in database converters, and enhanced back navigation handling in the UI. The changes also include dependency upgrades and version bumps to keep the project up-to-date.
Build System and Dependency Updates:
kapttokspfor both Room and Hilt, and updated Hilt dependencies to version 2.60.1. Also updated Gradle from 9.1.0 to 9.6.1 and enabled parallel sync for improved build performance. [1] [2] [3] [4]Database Type Safety Improvements:
TypeConvertermethods inConverters.ktto use non-nullableArrayListtypes, add null/empty checks, and remove unnecessary nullability, improving type safety and preventing potential crashes.UI/UX Enhancements:
onBackPressedoverrides in bothMainActivityandCastCrewDetailsActivitywith the modernonBackPressedDispatcher.addCallbackapproach, ensuring proper back navigation and fragment dismissal behavior. [1] [2] [3] [4]Version and Target Updates:
targetSdkVersionto 36, incrementedversionCodeto 24, and updatedversionNameto 3.1.0 in bothbuild.gradleandpreference.xmlto reflect the new release. [1] [2]Cleanup and Modernization:
kotlinOptionsandkaptblocks frombuild.gradle, aligning with the migration toksp.These changes collectively improve the codebase's maintainability, safety, and user experience.