Fix hasSO detection in scoring to respect linked SO accounts with no activity - #86
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: sajeetharan <4833351+sajeetharan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comment
Fix hasSO detection in scoring to respect linked SO accounts with no activity
Aug 7, 2026
sajeetharan
marked this pull request as ready for review
August 7, 2026 14:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
computeScore()determinedhasSOpurely fromsoReputation > 0 || soAnswers > 0, so a developer with a linked Stack Overflow account (soUserIdpresent) but zero recorded activity was treated as having no SO presence, triggering weight redistribution to GitHub dimensions and UI copy that contradicted the actual SO link.lib/scoring.js:hasSOnow also checksdev.soUserId, OR-ing it with the existing reputation/answers heuristic for backward compatibility.