Add city rankings and city rank badges - #81
Merged
Conversation
|
@pradipNP is attempting to deploy a commit to the sajeetharan's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Hi @sajeetharan, This PR implements the city-level ranking portion that remained after the country-ranking MVP. I've tested the changes locally and the build passes successfully. Feedback is welcome. Thanks for reviewing! |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds city-level ranking support alongside existing global/country ranks, and surfaces city rank badges in the developer detail UI and share card rendering.
Changes:
- Added city extraction + normalization helpers (
extractCity,normalizeCity,cityKey) alongside existing country utilities. - Extended the ranking pipeline to compute per-city ranks (scoped by country + city) and attach
cityRank/cityTotal/cityonto developer records. - Updated UI styling and rendering to display city rank badges in the detail panel and include a city rank block on generated share cards.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| styles/main.css | Adds stacked badge layout + city badge styling. |
| lib/ranking.js | Computes and merges city rank metadata into developer records. |
| lib/country.js | Adds city parsing/normalization utilities used by ranking. |
| components/DetailPanel.jsx | Renders city rank badge under the country badge. |
| app/api/card/route.jsx | Adds optional city rank block and adjusts rank card widths accordingly. |
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the city-level ranking portion of #25 and implements the follow-up issue #80.
Changes
Notes
lib/ranking.jsCloses #80