Repository navigation
Fix the local stack: compose file and make test - #18
Merged
Merged
Conversation
The two services were appended after the top-level volumes: key, so compose parsed them as volume definitions and refused the file outright: volumes.grafana additional properties 'depends_on', 'environment', 'image', 'ports', 'volumes' not allowed That is a validation error, not a partial failure, so every compose command failed and took `make db`, `make up` and the quickstart down with them — including `make test`, which needs the database `make db` starts. The volumes block now sits at the end of the file where it cannot swallow a service.
TEST_DB was declared and never used, so `make db && make test` — what the README tells you to run — failed with "MODELFORGE_TEST_DATABASE_URL is not set" unless you already knew to export it yourself. The test target now passes TEST_DB through under the name the suite reads. DB and TEST_DB both fall back to MODELFORGE_DATABASE_URL and MODELFORGE_TEST_DATABASE_URL when those are set, so pointing the whole thing at a Postgres you already have is one export rather than an argument on every target. The quickstart documents that path, since 5432 being taken is the ordinary case on a machine that has run any other project.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Sep 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo built and CI was green, but nothing in the local quickstart actually ran. Two separate breaks, both outside the code CI exercises.
deploy/docker-compose.ymlwas invalid. Prometheus and Grafana were appended after the top-levelvolumes:key, so compose parsed them as volume definitions and rejected the file:Validation fails before anything starts, so
make db,make upand the whole quickstart were down — andmake testwith them, since it needs the databasemake dbbrings up. This has been true since the observability stack landed inad3834b. CI never caught it because CI uses a service container rather than this file.make testcould not reach that database anyway.TEST_DBwas declared in the Makefile and never used, somake db && make test— exactly what the README says to run — failed withMODELFORGE_TEST_DATABASE_URL is not setunless you already knew to export it by hand.Also documents the non-Docker path:
DBandTEST_DBnow fall back toMODELFORGE_DATABASE_URL/MODELFORGE_TEST_DATABASE_URL, so pointing everything at a Postgres you already have is one export. Port 5432 already being taken is the ordinary case, not the exception.Verified end to end against the fixed file, with the server on
:8080:docker compose configvalidates;prometheus,grafanaandpostgresall resolve as servicesmodelforgealert rule group, and scrapes the server with its read token —up{job="modelforge"} = 1modelforgedashboard and the Prometheus datasourcemake tokens→create→push→deploy→predictreturns a prediction; a 90/10 canary split 56/5 across 61 requests;shadow,policy,stats,baseline,driftandrollbackall behave as documented; the dashboard renders at/make testnow runs the full suite offTEST_DBalone: all packages pass, coverage 89.9%, matching the figure in the README