Skip to content

chore: CI/CD improvements — frontend build check, health check, rollback #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saggacce merged 2 commits into from
May 31, 2026
Merged

chore: CI/CD improvements — frontend build check, health check, rollback #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa21df5
chore: CI/CD — frontend build in CI, health check + rollback on deploy
saggacce May 31, 2026
487f5d6
fix: t() nav.invitations and add i18n keys
saggacce May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 53 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,25 +13,32 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 20
cache: npm

- name: Install dependencies
run: npm ci

- name: Generate Prisma Client
run: npx prisma generate --schema=workers/data-sync/prisma/schema.prisma
- name: Type-check

- name: Type-check (backend + shared)
run: npx tsc --noEmit

- name: Build frontend (catches tsc -b errors missed by root tsconfig)
run: cd apps/web && npm run build

- name: Run tests
run: npx vitest run

deploy:
name: Deploy to production
runs-on: ubuntu-latest
needs: ci
# Only deploy when a sprint PR is merged into main
if: github.ref == 'refs/heads/main' && github.event_name == 'push'
environment:
name: production
Expand All @@ -47,23 +54,62 @@ jobs:
set -e
cd /var/opt/riftline/app

# ── Save current commit for rollback ────────────────────────────
PREVIOUS_COMMIT=$(git rev-parse HEAD)
echo "→ Current commit: $PREVIOUS_COMMIT"

# ── Pull latest code ────────────────────────────────────────────
echo "→ Pulling latest code..."
git fetch origin
git reset --hard origin/main
NEW_COMMIT=$(git rev-parse HEAD)
echo "→ New commit: $NEW_COMMIT"

# ── Install dependencies ────────────────────────────────────────
echo "→ Installing dependencies..."
npm install --prefer-offline

# ── Prisma ──────────────────────────────────────────────────────
echo "→ Generating Prisma client..."
npx prisma generate --schema=workers/data-sync/prisma/schema.prisma

# ── Build frontend (fail fast) ──────────────────────────────────
echo "→ Building frontend..."
cd apps/web && npm run build && cd ../..
cd apps/web
if ! npm run build; then
echo "✗ Frontend build failed — rolling back to $PREVIOUS_COMMIT"
cd /var/opt/riftline/app
git reset --hard "$PREVIOUS_COMMIT"

@chatgpt-codex-connector chatgpt-codex-connector Bot May 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore previous dist on frontend build rollback

When npm run build reaches the Vite phase and then fails, Vite prepares the output directory before writing (emptyOutDir defaults to true for an in-root dist), and apps/web/dist is gitignored while the running API serves that directory from disk in production. In that failure mode this rollback only resets tracked files, so the old PM2 process can continue serving an emptied or partially rewritten frontend until someone manually rebuilds the previous commit; rebuild the previous frontend (and restore deps if needed) before exiting this rollback path.

Useful? React with 👍 / 👎.

exit 1
fi
cd /var/opt/riftline/app

echo "→ Clearing tsx cache..."
# ── Restart API ─────────────────────────────────────────────────
echo "→ Clearing tsx cache and restarting API..."
rm -rf ~/.cache/tsx

echo "→ Restarting API..."
pm2 restart riftline-api --update-env

echo "✓ Deploy complete — https://riftline.app"
# ── Health check ────────────────────────────────────────────────
echo "→ Health check..."
sleep 5
MAX_RETRIES=6
for i in $(seq 1 $MAX_RETRIES); do
STATUS=$(curl -s -o /dev/null -w "%{http_code}" http://localhost:3001/health || echo "000")
if [ "$STATUS" = "200" ]; then
echo "✓ Health check passed (attempt $i) — https://riftline.app"
exit 0
fi
echo " Attempt $i/$MAX_RETRIES: status $STATUS — retrying in 5s..."
sleep 5
done

# ── Rollback if health check failed ────────────────────────────
echo "✗ Health check failed after $MAX_RETRIES attempts — rolling back to $PREVIOUS_COMMIT"
git reset --hard "$PREVIOUS_COMMIT"
npm install --prefer-offline
npx prisma generate --schema=workers/data-sync/prisma/schema.prisma
cd apps/web && npm run build && cd /var/opt/riftline/app
rm -rf ~/.cache/tsx
pm2 restart riftline-api --update-env
echo "✓ Rollback complete"
exit 1
2 changes: 1 addition & 1 deletion apps/web/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ function useSections(t: (key: string) => string): SidebarSection[] {
icon: <Settings size={17} />,
items: [
{ to: '/admin/users', label: t('nav.users') },
{ to: '/admin/invitations', label: t('nav.invitations', { defaultValue: 'Invitaciones' }) },
{ to: '/admin/invitations', label: t('nav.invitations') },
{ to: '/admin/data-quality', label: t('nav.dataQuality') },
{ to: '/management/roles', label: t('nav.rolesPermissions') },
{ to: '/admin/api-status', label: t('nav.apiStatus') },
Expand Down
Loading