Skip to content

feat: add bytecode consistency review for module deployment PRs - #193

Open
falvaradorodriguez wants to merge 1 commit into
mainfrom
feat/cross-chain-bytecode-verification
Open

feat: add bytecode consistency review for module deployment PRs#193
falvaradorodriguez wants to merge 1 commit into
mainfrom
feat/cross-chain-bytecode-verification

Conversation

@falvaradorodriguez

@falvaradorodriguez falvaradorodriguez commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • update-registry.yml writes new addresses with zero on-chain verification, only format checks. Nothing confirms the bytecode is actually correct.
  • Unlike safe-deployments, this schema has no stored codeHash per chain, so adds a Review workflow (mirrors safe-deployments' review.yml) that instead cross-checks: on PRs touching src/assets/**, diffs each changed file against the base commit to find which chain(s) changed, then verifies each one's bytecode hash against an already-registered reference chain (deterministic CREATE2 deploys must be byte-identical everywhere).
  • Only changed chains are checked, and all of them are checked before failing (not just the first broken one).

@falvaradorodriguez
falvaradorodriguez requested a review from a team as a code owner July 15, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant