Repository navigation
Center table ornaments and mirror decorative details - #6
Merged
Merged
Conversation
saeedet
marked this pull request as ready for review
October 25, 2026 09:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four-suit rows were visibly right of the table center because the captured text frames were offset and their SVGs included unequal side padding. Other theme wordmarks and the Royal Burgundy crown had similar offsets. Center the visible outlines while preserving their paths, scale and vertical placement.
Both PokerTable and TableSurface now use the same alignment rules at canonical, portrait, landscape, circular and intermediate proportions. Royal Burgundy studs form mirrored quartets around both axes, and Neon Night/Ocean Slate texture cells anchor to the table center. Art Deco's mirrored chevrons are verified, and both three-diamond rows are horizontally centered with equal spacing and a vertical midpoint between the paired gold contours. Portrait is checked with both automatic and approved mobile material sizing. The surface demo places its player badges on the outer rail so neither diamond row is obscured. Material paints, rails, felt, lighting, shadows and gameplay anchors remain compatible. The original captured specification and SVG sources are unchanged.
Prepare FeltForge 0.4.1 and document the corrections. The approved release publishes through the existing tag-triggered workflow after this PR is merged and main passes CI.
Validation passed for commit
2d4c277: formatting, lint, types, build, 133 unit/SSR/rendering tests, deterministic table and asset generation, standalone asset visual checks, package checks, actual tarball React 18/Next.js consumers, and 32 Chromium/mobile WebKit checks. Browser assertions measure visible outline centers, equal diamond spacing, position between gold lines and clearance from demo badges across desktop, portrait, landscape, circle and intermediate proportions. Portrait covers automatic and approved mobile material sizing. Browser screenshots were visually inspected.CI: https://github.com/saeedet/feltforge/actions/runs/40181807229
The full-render 0.3.0 snapshots are replaced with material-only snapshots captured from the unmodified 0.4.0 renderer before this fix. The same helper removes only the intentionally realigned lettering, studs, diamond rows and textures from old and new renders; every remaining pixel must match exactly. Independent Penpot references still verify interior materials, excluding corrected ornament positions. Dedicated centering and symmetry tests verify the changed artwork separately. This preserves meaningful regressions without accepting the known alignment defects as the expected image.