Repository navigation
fix: align chip rims with updated Penpot design - #3
Merged
Merged
Conversation
saeedet
marked this pull request as ready for review
October 15, 2026 10:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the chip renderer with the current Penpot master: a separate, continuous 1px inner Rim above all eight Edge Inserts and below Inner Ring.
CHIP.rimdefines the black color, 28% opacity and width. Single chips, custom denominations and every visible stack layer use the same geometry, scaled with chip size.The existing renderer already drew an equivalent rim above the inserts. This update makes the layer order and stroke width explicit and records the inspected Penpot master and canonical instances. It does not add a second border or thicken the existing rim.
The playground adds One continuous edge under Chips & markers, with 4× close-ups of light, dark and custom chips without shadows. The README and API reference describe the border. Contact shadows and live denomination labels continue to work; no font files or static chip assets are imported.
Validation passed: formatting, lint, strict types, 89 unit/rendering tests, asset and package inspection, React 18 and Next.js tarball consumers, and all 14 browser checks. A raster regression verifies the border over every insert on all seven standard denominations and the custom chip; stack checks verify a rim on every visible layer. Desktop and mobile WebKit close-ups have been reviewed. Successful CI run, screenshots and downloadable playground preview.
Merged and released as FeltForge 0.2.2. npm is verified at 0.2.2 with the latest tag; the public playground includes the new rim close-ups. Successful publishing pipeline.