Skip to content

chore: drop PHP 7.4 8.0 8.1 support PHP 8.2 up#280

Merged
phil-davis merged 4 commits into
sabre-io:masterfrom
phil-davis:php82
May 31, 2026
Merged

chore: drop PHP 7.4 8.0 8.1 support PHP 8.2 up#280
phil-davis merged 4 commits into
sabre-io:masterfrom
phil-davis:php82

Conversation

@phil-davis
Copy link
Copy Markdown
Contributor

@phil-davis phil-davis commented Apr 27, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.98%. Comparing base (8989fcb) to head (4d71e5b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/functions.php 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #280      +/-   ##
============================================
- Coverage     94.15%   93.98%   -0.18%     
  Complexity      263      263              
============================================
  Files            15       15              
  Lines           873      864       -9     
============================================
- Hits            822      812      -10     
- Misses           51       52       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phil-davis
Copy link
Copy Markdown
Contributor Author

https://github.com/sabre-io/http/actions/runs/26706488794/job/78708639025?pr=280

rector has run successfully.

And all the other CI (cs-fixer, phpstan, phpunit).

Comment thread composer.json
"phpstan/phpstan-strict-rules": "^2.0",
"phpstan/extension-installer": "^1.4",
"phpunit/phpunit" : "^9.6",
"phpunit/phpunit" : "^10.5",
Copy link
Copy Markdown
Member

@staabm staabm May 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could even go phpunit 11+ with php 8.2+
(but maybe in a separate PR)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could even go phpunit 11+ with php 8.2+ (but maybe in a separate PR)

True. For some reason I only went to PHPunit10 in the other repos. So I will be consistent for now.

@phil-davis phil-davis merged commit ab6441e into sabre-io:master May 31, 2026
4 of 6 checks passed
@phil-davis phil-davis deleted the php82 branch May 31, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants