Improve YAML reader error handling - #149
Open
creideiki wants to merge 4 commits into
Open
Conversation
Add a base class PalletJack::Error for all internal errors, and PalletJack::WarehouseError for semantic errors in the warehouse.
Boxes may legitimately be empty e.g. by commenting things out while debugging. Otherwise, they must be hashes in order to be merged into the greater data tree. Throw a PalletJack::WarehouseError, naming the offending box, if this constraint is violated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow boxes to be empty or YAML hashes, throw errors for everything else.
Testing warehouse error handling is difficult, since pallets cannot exist stand-alone, and it seems like overkill to include an entire (admittedly tiny) warehouse for each kind of error.
Closes #128.
This is a bug fix, and should bump the patch version.
Changelog: