Repository navigation
A click that opens the side panel no longer flings the box across the canvas - #59
Merged
Merged
Conversation
… canvas Clicking a box selects it, which opens the side panel; the splitter narrows the canvas, whose resizeEvent (and the page's deferred fit) re-fit the view with auto_fit on, all while the left button is still down on the box. A movable item's drag anchor is a scene point taken at the press, so once the view's transform has changed under the pointer, the first pixel of movement moves the box by the whole difference: on a template canvas a 1 px move took a box from (300, 0) to (500, 10). GraphView now notes a fit asked for while the left button is down on it and does it at the release (or at the first move that finds the button up, when it was released outside the window). Both fits, GraphView's and the workflow canvas's, go through the same guard. A test presses a box, lets the panel open, moves a pixel and releases, and checks the box stayed and the fit came afterwards. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0159iy7dUgYeve4qV1z4FhUa
s4mstruthers
added a commit
that referenced
this pull request
Oct 12, 2026
The fix merged in #59 landed after the 0.11.0 tag, so its changelog line moves into a section of its own and the version, CITATION.cff and its release date follow. Claude-Session: https://claude.ai/code/session_0159iy7dUgYeve4qV1z4FhUa Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking a box selects it, which opens the side panel; the splitter narrows
the canvas, whose resizeEvent (and the page's deferred fit) re-fit the view
with auto_fit on, all while the left button is still down on the box. A
movable item's drag anchor is a scene point taken at the press, so once the
view's transform has changed under the pointer, the first pixel of movement
moves the box by the whole difference: on a template canvas a 1 px move took
a box from (300, 0) to (500, 10).
GraphView now notes a fit asked for while the left button is down on it and
does it at the release (or at the first move that finds the button up, when
it was released outside the window). Both fits, GraphView's and the
workflow canvas's, go through the same guard. A test presses a box, lets
the panel open, moves a pixel and releases, and checks the box stayed and
the fit came afterwards.
Co-Authored-By: Claude Fable 5.1 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_0159iy7dUgYeve4qV1z4FhUa