Add term_variables/2, numbervars/3, and =@=/2 to the JS WAM - #4197
Open
s243a wants to merge 2 commits into
Open
Conversation
Port the Rust/Clojure term-meta walks onto the existing copy_term depth-first deref walk. numbervars binds+trails '$VAR'(N). =@= uses a consistent var bijection; \=@= is its negation. write/1 still prints '$VAR'(N) literally, not SWI letter rendering. Co-authored-by: johns243a <johns243a@gmail.com>
\+ compiled as ITE undoes Y registers allocated only inside the try branch, so f(T,T) \=@= f(U,V) must mention T/U/V first. Co-authored-by: johns243a <johns243a@gmail.com>
s243a
marked this pull request as ready for review
August 30, 2026 17:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes G-W3 follow-up: the JS WAM was missing
term_variables/2,numbervars/3,=@=/2, and\=@=/2.Semantics (SWI)
term_variables(+Term,-List): distinct unbound vars, first-occurrence L-to-R depth-first.numbervars(+Term,+Start,-End): bind+trail each distinct unbound var to'$VAR'(N)from Start; End is Start+count.write/1prints'$VAR'(N)literally (no letter-styleA/Brendering).=@=/2: variant equality (ground as==; vars via a consistent bijection).\=@=/2is the negation.Walks reuse the
copy_termderef +seencycle guard.Tests (green locally)
Parser probes, fact sources, 48-query local suite, and lowered emitter stay green.
Branched from
grok/wamjs-fact-sourcesand extended it. Shared files are not edited.