Skip to content
This repository was archived by the owner on Mar 25, 2026. It is now read-only.
This repository was archived by the owner on Mar 25, 2026. It is now read-only.

QuickFilterDropdown violates headless architecture with hardcoded styles #96

Closed

Description

@ryanrozich

Problem

QuickFilterDropdown component has CSS module styles (QuickFilterDropdown.module.css) which violates the headless component architecture principle. Headless components should have NO default styles.

Current Issues

  1. Component has 643 lines of CSS with hardcoded colors and styles
  2. Dark mode only works with prefers-color-scheme: dark media query, not class-based dark mode
  3. Users cannot fully customize the component appearance without fighting specificity wars

Files Affected

  • src/components/QuickFilterDropdown/QuickFilterDropdown.module.css (should be removed)
  • src/components/QuickFilterDropdown/index.tsx (should remove all style imports and className applications)

Proposed Solution

  1. Remove ALL CSS from the component
  2. Accept render props or className props for each element
  3. Provide example styles in the demo/documentation
  4. Let users have full control over styling

Temporary Workaround

Created src/demo/styles/quick-filter-overrides.css with !important rules to fix dark theme hover states in the demo.

Related

Activity

  1. ryanrozich commented on Jul 15, 2025

    @ryanrozich
    OwnerAuthor

    This issue has been resolved by PR #102 (Release v0.2.0-rc3). The QuickFilterDropdown component has been completely rewritten using the headless UI pattern, eliminating all architecture violations.

    The new implementation properly separates logic from presentation and follows the established headless component patterns.

    See HEADLESS_RC3_MIGRATION_PLAN.md for details.

  2. moved this from 📥 Needs Triage to ✅ Done in AG Grid React Components Roadmapon Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions