Fix potential stack overflow in _wait_until_complete

[laz-]

Summary

_wait_until_complete currently calls itself recursively while waiting for the NetFunnel queue. Under sustained high-traffic conditions the queue wait can be long enough for the recursion depth to grow unboundedly, risking a RecursionError.

This PR converts the implementation to an equivalent iterative while loop, which has identical behaviour with no stack risk.

Changes

• SRT/netfunnel.py: replace recursive _wait_until_complete with a while True loop; key is updated in-place each iteration instead of being passed as a new recursive argument.

Test plan

• Existing behaviour is unchanged — the loop still polls chkEnter, sleeps 1 s while nwait != 0, and returns the key once the queue clears
• No new dependencies or interface changes

🤖 Generated with Claude Code

[gemini-code-assist]

Code Review

This pull request refactors the recursive _wait_until_complete method in SRT/netfunnel.py into an iterative while True loop to avoid potential recursion limit issues. The review feedback suggests adding an explicit timeout parameter to the HTTP GET request to prevent the application from hanging indefinitely during high-traffic periods.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

Under high-traffic conditions (when NetFunnel is typically active), the server is more likely to experience high load, leading to dropped connections or extremely slow responses. Since requests.get has no default timeout, the call can hang indefinitely, causing the application to freeze. Adding an explicit timeout parameter prevents this.

Suggested change

	resp = self.session.get(
	self.NETFUNNEL_URL,
	params=params,
	)
	resp = self.session.get(
	self.NETFUNNEL_URL,
	params=params,
	timeout=10,
	)

[ryanking13]

Well, I doubt there would be a large number of recursive calls normally. Did you ever face this situation?