Skip to content

fix: prevent NPE when Camera.entity is null #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CaiBai-Fish wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

fix: prevent NPE when Camera.entity is null #778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion neoforge/src/main/java/dev/ryanhcode/sable/neoforge/mixin/camera_rotation/CameraMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;

@Mixin(Camera.class)
public abstract class CameraMixin {
公共 abstract class CameraMixin {

@Shadow
@Final
Expand Down Expand Up @@ -69,6 +69,10 @@ public abstract class CameraMixin {

@WrapMethod(method = "setPosition(Lnet/minecraft/world/phys/Vec3;)V")
private void sable$setPosition(final Vec3 arg, final Operation<Void> original) {
if (this.entity == null) {
original.call(arg);
return;
}
final Level level = this.entity.level();

final ClientSubLevel subLevel = (ClientSubLevel) Sable.HELPER.getContaining(level, arg);
Expand Down