CLAUDE.md: the CI table said Android was disabled; it has not been - #1560
Merged
Conversation
The table's whole job is telling a contributor what validates their change, and it was wrong about that in two directions. android.yml is listed as "disabled (compile Android locally)". It is active, and path-filtered to android/**, so it has been running assembleFullDebug + testFullDebugUnitTest on every Android-touching PR. The green "build-and-test" check on those PRs IS Android CI -- easy to misattribute when the table says the workflow is off, which is exactly what happened while writing #1559. Three more active PR gates were missing from the table entirely: source-hygiene.yml (the detached-doc-comment lint), i18n-coverage.yml (the diff-scoped translation gate) and tools-python.yml (the Tools/ suites). All three can fail a PR, and none of them appeared in the one place a contributor is told what runs. prune-stale-branches.yml is listed too, since it acts on the repo on a schedule. Every workflow in .github/workflows is now in the table, verified against the live workflow states rather than transcribed. Left alone deliberately: app-build.yml really is disabled_manually, so the row above and the "trap" paragraph below -- which warn that no default CI compiles app-target Swift -- are both still accurate and still the most important thing on this page. Docs only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI table's whole job is telling a contributor what validates their change, and it was wrong about that in two directions.
android.ymlis active, not disabledIt is listed as disabled (compile Android locally). It is active, path-filtered to
android/**, and has been runningassembleFullDebug+testFullDebugUnitTeston every Android-touching PR.The green
build-and-testcheck on those PRs is Android CI. That is easy to misattribute when the table says the workflow is off — which is exactly what happened while writing #1559: I reported the Kotlin change as covered only by a local run, when CI had already built and tested it.Three active PR gates were missing entirely
source-hygiene.ymli18n-coverage.ymltools-python.ymlTools/suitesAll three gate pull requests. None appeared in the one place a contributor is told what runs.
prune-stale-branches.ymlis listed too, since it acts on the repo on a schedule.Every workflow in
.github/workflowsis now in the table, checked against the live workflow states rather than transcribed from the old text.Left alone deliberately
app-build.ymlreally isdisabled_manually. That row and the trap paragraph under it — the warning that no default CI compiles app-target Swift — are both still accurate, and still the most important thing on that page. Nothing here softens them.Docs only.