chore: re-initialize repos/effect/ as proper git subtree#55
Merged
Conversation
The directory was originally committed directly rather than via `git subtree add`, so `git subtree pull` fails with "was never added". Removing first so it can be re-added with proper subtree metadata. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
git-subtree-dir: repos/effect git-subtree-split: e71ba68273026a1a2c1ace7218bdb206b0d3386d
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No new issues found.
TL;DR — Re-initializes repos/effect/ as a proper git subtree so that git subtree pull succeeds and the scheduled vendor-update workflow actually works.
Key changes
- Remove and re-add
repos/effect/viagit subtree— The directory was originally committed directly, which brokegit subtree pull. The three-file diff (changeset, one-line source fix inspan.ts, and a test) is the natural delta between the old directly-committed state and the upstream ate71ba6827; no intentional modifications.
Summary ｜ 3 files ｜ 3 commits ｜ base: main ← chore/fix-effect-subtree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repos/effect/directory was originally committed directly into the repo, not viagit subtree addgit subtree pullto fail withfatal: can't squash-merge: 'repos/effect' was never addedupdate-effect-vendor.ymlworkflow appeared to succeed but never actually updated anythingrepos/effect/and re-add it viagit subtree add --squash, creating the merge metadata git needs for future pullsTest plan
git subtree pull --prefix=repos/effectnow succeeds locally (reports "Subtree is already at commit...")Update vendored Effect sourceworkflow and confirm it completes correctly🤖 Generated with Claude Code