sp pin/unpin — exempt scratches from reaping - #37
Merged
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34
Adds a first-class pin so a scratch can be kept safe from
sp reapwithout lying about its TTL.What changed
Scratch.Pinned bool(json:"pinned,omitempty") — backward-compatible; absent key decodes to false on existing indexes.SetPin(id, pinned)(metadata-only, idempotent).Reap(and--dry-run) now skips pinned live scratches and tallies them inReapPlan.PinnedSkipped.sp pin <id>/sp unpin <id>registered on root, with tombstone-flavored, idempotent confirmations. Reap summary reports how many pins it spared.sp lsshows 📌 on a TTY,PINtoken in plain output;--jsoncarries"pinned": true. Secret 🔑 marker unchanged.sp ls/quickstart help updated.Tests
pinnedin JSON, reap summary skip note (incl. the "nothing to reap" line).All acceptance-criteria boxes covered.
go build,go vet,go test ./...green; new/changed files gofmt-clean.