sp stats — fun store metrics - #35
Merged
Merged
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32
Adds
sp stats: a read-only metrics report over the index.What it reports
--jsonfor scripting (color/personality-free), mirroringls --json/doctor --json.oldestis null on empty store;tagsalways an array.Structure follows existing patterns: computation in
internal/store/stats.go(plain data), rendering ininternal/render/stats.go, command ininternal/cli/stats.goadapting store→render types (same one-way dependency arrow doctor/reap use).Tests cover empty store, mixed live/morgue, purgeable counting, oldest-survivor selection, tag-breakdown ordering, morgue tags excluded, JSON shape + null-oldest zero-state, and full command wiring.
README updated with a
sp statssection + quickstart lines.Acceptance criteria all met. All tests +
go vetgreen.