M6: tombstone-flavored personality for command confirmations - #23
Merged
Conversation
M6 polish: bring the direct command confirmation lines (new/open/rm/resurrect/promote) up to the same tasteful tombstone voice the render layer already has, without disturbing the stable output anchors tests and scripts rely on. - sp new now notes the scratch's 'borrowed time' + a compact expiry countdown - sp open: 'back on the slab'; sp rm: 'buried in the morgue, not gone, just resting' - sp resurrect: 'claws its way out of the morgue'; sp promote: 'escapes the reaper' - new helpers lifespanNote/humanCountdown are pure + unit-tested - personality_test.go pins the flavor and guards the anchors (created scratch / morgue / live again / promoted scratch) - README rm example refreshed to match Anchors preserved; build/vet/gofmt/tests all green.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #6 (M6 — Polish + personality + ship v0.1.0)
What & why
M6's first acceptance criterion asks for "tombstone-flavored personality in user-facing messages (tasteful, not noisy)." The render layer (
ls,--morgue,reap,doctor) already had that voice, but the direct command confirmation lines were still clinical. This brings them in line.Changes
sp new→created scratch <id> (name) — living on borrowed time, expires in ~7d(new pure helperslifespanNote/humanCountdown).sp open→… — back on the slabsp rm→buried scratch <id> (name) in the morgue — not gone, just resting; restore with \sp resurrect ``sp resurrect→… — it claws its way out of the morgue and is live againsp promote→… — it escapes the reaper and joins the working treeinternal/cli/personality_test.gopins the new flavor and guards the stable substrings other tests/scripts depend on (created scratch,morgue,live again,promoted scratch).sp rmexample refreshed to match.Guarantees
--json/scripting output touched (personality lives only on human confirmation lines).go build,go vet,gofmt -l, and the fullgo test ./...suite are all green.Sample
Deliberately NOT in this PR
The remaining M6 item — tagging and publishing the
v0.1.0release (which triggers the GoReleaser release workflow and publishes artifacts) — is a maintainer action and is intentionally left for a human to cut, not automated here. #6 stays open until that ships.