feat: wire SSE core into VS Code response panel + directives (#46)#52
Open
rwrife wants to merge 1 commit into
Open
feat: wire SSE core into VS Code response panel + directives (#46)#52rwrife wants to merge 1 commit into
rwrife wants to merge 1 commit into
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46 (partially — first shippable slice).
What changed
src/core/sse/directives.ts— pure mapping from.httpdirectives (@sse-until,@sse-max-events,@sse-max-duration-ms,@sse-idle-ms) to a validatedSseTransportUserOptionsobject, plus anisSseResponsehelper. Zod-validated. Bad numeric values are surfaced as diagnostics, not silently dropped.renderSseResponseinsrc/extension/responseView.ts— streaming-mode response panel that shows a scrolling event list with type / id / elapsed / timestamp, pretty-prints JSONdata, and toggles between a "● streaming" and "■ " pill.runRequestnow detectstext/event-streamon the undici response and hands off to a newstreamSseResponsehelper that drives the existing purerunSseTransportover the decoded body, refreshing the webview on every event and surfacing@sse-untilcompile/runtime errors as a warning banner.What's left for #46
Last-Event-IDretry loop (transport already tracks state; needs a socket-owning wrapper)..sse.jsonltranscript command (formatSseTranscriptLinealready exists in core).@vscode/test-electron.Small, focused slice — no drive-by refactors, no changes to the existing HTTP path when the response isn't SSE.