Pests & weeds: reverts spawn cosmetic aphids (#23) - #26
Merged
Merged
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23
Introduces gentle negative signals: revert commits spawn cosmetic pests (aphids/weeds) on the plant that you clear by returning to a healthy commit cadence. Purely visual + moral — never lowers stage, streak, or health.
What changed
internal/gitstat:Activitygains aReverts intwindow aggregate. Reverts are detected purely from the conventionalRevert "…"commit subject (added%sto the log pretty-format) — no commit content/diffs read (honors PLAN.md §9). Fixture-covered, including prose "revert" false-positive rejection and out-of-window exclusion.internal/plant:pestsFormapsReverts→ a boundedPests int(clamped toMaxPests = 3), pure and unit-tested. Never touches Stage/Streak/Health. Clears after a clean healthy commit today (real work, not just more reverts).internal/render: draws pests as%glyphs overlaid on the foliage, with a caption hint. Overlaid on raw art before the color pass so ANSI stays intact; degrades cleanly under--no-color/NO_COLOR/piped output.cmd:--no-pestsflag disables the overlay entirely (visual-only opt-out).Acceptance criteria
gitstat.Activity.Revertsparsed fromgit log, fixture testsinternal/plantboundedPests, pure + unit-tested, never lowers Stage/Streakinternal/renderdraws pest glyphs, degrades under--no-color--no-pestsflaggo build ./...andgo test ./...passManually verified end-to-end against a repo with revert commits (pests appear, cap at 3, clear on clean commit,
--no-pestssuppresses).