feat: add per-target lifecycle event opt-outs (events, time_tracking)#36
Open
CraZySacX wants to merge 6 commits into
Open
feat: add per-target lifecycle event opt-outs (events, time_tracking)#36CraZySacX wants to merge 6 commits into
CraZySacX wants to merge 6 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #36 +/- ##
==========================================
+ Coverage 88.18% 88.36% +0.17%
==========================================
Files 11 11
Lines 3784 3859 +75
==========================================
+ Hits 3337 3410 +73
- Misses 447 449 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
CraZySacX
changed the title
Adds an optional `events` field (default `true`) to `[target.X]` that, when set to `false`, suppresses that target's before/after lifecycle events and all nested command/tool events, regardless of the top-level `[lifecycle]`/license gating.
…event Adds an optional `time_tracking` field (default `true`) to `[target.X]` that, when set to `false`, fires a `no_time_tracking` lifecycle event immediately after that target's `before_target` event, so external time-tracking integrations can see the opt-out inline in the stream. Mirrors the existing `events` opt-out's implementation pattern. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
CraZySacX
force-pushed
the
35-v051-enhancements
branch
from
ecc2d56 to
6bff2bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eventsfield (defaulttrue) so a[target.X]can opt out of lifecycle events entirely — its before/after events and all nested command/tool events are suppressed regardless of the top-level[lifecycle]/license gatingtime_trackingfield (defaulttrue) so a[target.X]can fire ano_time_trackinglifecycle event immediately after itsbefore_targetevent, letting external time-tracking integrations see the opt-out inline in the streamcoverage_nightlycfg attribute left inrake/src/main.rsCargo.lockwith the latest compatible dependency versions