Edits to docs with more testing

ec/examples/ec_demo.rs

@@ -1,4 +1,4 @@
-use crypto_bigint::{const_prime_monty_params, Uint};
+use crypto_bigint::{Uint, const_prime_monty_params};
 
 use ec::curve_edwards::EdwardsCurve;
 use ec::curve_jacobi_intersection::JacobiIntersectionCurve;
@@ -64,4 +64,4 @@ fn main() {
     // Need a != 0, 1.
     let ji = JacobiIntersectionCurve::new(fp(2));
     show_curve("Jacobi intersection", &ji, &mut rng);
-}
+}

ec/src/curve_edwards.rs

@@ -28,10 +28,10 @@
 //! - Binary Edwards curves (characteristic $2$): Bernstein–Lange–Rezaeian Farashahi (2008)
 //! - Odd characteristic: <https://hyperelliptic.org/EFD/g1p/auto-edwards.html>
 
-use subtle::{Choice, ConditionallySelectable, ConstantTimeEq};
-use fp::{ref_field_impl, ref_field_trait_impl};
 use core::fmt;
 use fp::field_ops::{FieldOps, FieldRandom};
+use fp::{ref_field_impl, ref_field_trait_impl};
+use subtle::{Choice, ConditionallySelectable, ConstantTimeEq};
 
 use crate::curve_ops::Curve;
 use crate::point_edwards::EdwardsPoint;
@@ -48,7 +48,6 @@ pub struct EdwardsCurve<F: FieldOps> {
     pub d2: F,
 }
 
-
 impl<F> fmt::Display for EdwardsCurve<F>
 where
     F: FieldOps + fmt::Display,
@@ -82,7 +81,6 @@ where
     }
 }
 
-
 ref_field_impl! {
     impl<F: FieldOps + FieldRandom> EdwardsCurve<F> {
         /// Construct an odd-characteristic Edwards curve `x² + y² = 1 + d·x²·y²`.
@@ -181,26 +179,7 @@ ref_field_impl! {
     }
 }
 
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-ref_field_trait_impl!{
+ref_field_trait_impl! {
     impl<F: FieldOps + FieldRandom> Curve for EdwardsCurve<F> {
         type BaseField = F;
         type Point = EdwardsPoint<F>;
@@ -261,7 +240,6 @@ ref_field_trait_impl!{
     }
 }
 
-
 // ---------------------------------------------------------------------------
 // Constant-time functionalities
 // ---------------------------------------------------------------------------
@@ -299,4 +277,4 @@ where
     fn ct_ne(&self, other: &Self) -> Choice {
         !self.ct_eq(other)
     }
-}
+}

ec/src/curve_hessian.rs

@@ -45,14 +45,14 @@
 //! - EFD, projective Hessian formulas:
 //!   <https://www.hyperelliptic.org/EFD/g1p/auto-hessian-standard.html>
 
-use core::fmt;
-use fp::field_ops::{FieldOps, FieldRandom};
-use subtle::{Choice, ConditionallySelectable, ConstantTimeEq};
-use fp::{ref_field_impl, ref_field_trait_impl};
 use crate::curve_ops::Curve;
 use crate::curve_weierstrass::WeierstrassCurve;
 use crate::point_hessian::HessianPoint;
 use crate::point_weierstrass::AffinePoint;
+use core::fmt;
+use fp::field_ops::{FieldOps, FieldRandom};
+use fp::{ref_field_impl, ref_field_trait_impl};
+use subtle::{Choice, ConditionallySelectable, ConstantTimeEq};
 
 /// A generalized Hessian curve
 ///
@@ -82,7 +82,7 @@ where
     }
 }
 
-ref_field_impl!{
+ref_field_impl! {
     impl<F: FieldOps + FieldRandom> HessianCurve<F> {
         /// Construct a generalized Hessian curve
         ///
@@ -176,8 +176,7 @@ ref_field_impl!{
     }
 }
 
-
-ref_field_trait_impl!{
+ref_field_trait_impl! {
     impl<F: FieldOps + FieldRandom> Curve for HessianCurve<F> {
         type BaseField = F;
         type Point = HessianPoint<F>;
@@ -220,7 +219,6 @@ ref_field_trait_impl!{
     }
 }
 
-
 impl<F> ConditionallySelectable for HessianCurve<F>
 where
     F: FieldOps + Copy,
@@ -256,8 +254,7 @@ where
     }
 }
 
-
-ref_field_impl!{
+ref_field_impl! {
     impl<F: FieldOps> HessianCurve<F> {
         /// Return the EFD Hessian parameter `delta` for the ordinary Hessian model
         ///
@@ -404,4 +401,3 @@ ref_field_impl!{
         }
     }
 }
-

ec/src/curve_jacobi_intersection.rs

@@ -19,10 +19,10 @@
 //!
 
 use core::fmt;
-use subtle::{Choice, ConditionallySelectable, ConstantTimeEq};
 use fp::field_ops::{FieldOps, FieldRandom};
 use fp::{ref_field_impl, ref_field_trait_impl};
 use rand::{CryptoRng, Rng};
+use subtle::{Choice, ConditionallySelectable, ConstantTimeEq};
 
 use crate::curve_ops::Curve;
 use crate::curve_weierstrass::WeierstrassCurve;
@@ -100,7 +100,7 @@ ref_field_impl! {
     }
 }
 
-ref_field_impl!{
+ref_field_impl! {
     impl<F: FieldOps + FieldRandom> JacobiIntersectionCurve<F> {
         /// Sample a random affine point on this Jacobi‑intersection curve using the
         /// provided RNG.
@@ -183,4 +183,4 @@ where
     fn ct_ne(&self, other: &Self) -> Choice {
         !self.ct_eq(other)
     }
-}
+}

ec/src/curve_jacobi_quartic.rs

@@ -16,9 +16,9 @@
 //! `d(a²-d) ≠ 0`.
 
 use core::fmt;
-use subtle::{Choice, ConditionallySelectable, ConstantTimeEq};
 use fp::field_ops::{FieldOps, FieldRandom};
 use fp::{ref_field_impl, ref_field_trait_impl};
+use subtle::{Choice, ConditionallySelectable, ConstantTimeEq};
 
 use crate::curve_ops::Curve;
 use crate::point_jacobi_quartic::JacobiQuarticPoint;
@@ -48,11 +48,7 @@ where
                 self.a, self.d
             )
         } else {
-            write!(
-                f,
-                "y^2 = ({})x^4 + 2({})x^2 + 1",
-                self.d, self.a
-            )
+            write!(f, "y^2 = ({})x^4 + 2({})x^2 + 1", self.d, self.a)
         }
     }
 }
@@ -108,7 +104,7 @@ ref_field_impl! {
     }
 }
 
-ref_field_impl!{
+ref_field_impl! {
     impl<F: FieldOps + FieldRandom> JacobiQuarticCurve<F> {
         /// Sample a random affine point on this Jacobi quartic using the provided RNG.
         ///
@@ -134,7 +130,6 @@ ref_field_impl!{
     }
 }
 
-
 ref_field_trait_impl! {
     impl<F: FieldOps + FieldRandom> Curve for JacobiQuarticCurve<F> {
         type BaseField = F;
@@ -223,4 +218,4 @@ where
     fn ct_ne(&self, other: &Self) -> Choice {
         !self.ct_eq(other)
     }
-}
+}

ec/src/curve_legendre.rs

@@ -46,12 +46,12 @@
 //! - HongFeng Wu and RongQuan Feng,
 //!   *On the isomorphism classes of Legendre elliptic curves over finite fields*,
 //!   Sci. China Math. 54(9) (2011), 1885–1890.
+use crate::curve_ops::Curve;
+use crate::curve_weierstrass::WeierstrassCurve;
+use crate::point_legendre::LegendrePoint;
 use core::fmt;
 use fp::field_ops::{FieldOps, FieldRandom};
 use fp::{ref_field_impl, ref_field_trait_impl};
-use crate::curve_ops::Curve;
-use crate::point_legendre::LegendrePoint;
-use crate::curve_weierstrass::WeierstrassCurve;
 
 /// A Legendre elliptic curve over a field `F`.
 ///
@@ -73,7 +73,7 @@ pub struct LegendreCurve<F: FieldOps> {
     pub lambda: F,
 }
 
-ref_field_impl!{
+ref_field_impl! {
     impl<F: FieldOps + FieldRandom> LegendreCurve<F> {
         /// Construct the Legendre curve $y^2 = x(x-1)(x-\lambda).$
         pub fn new(lambda: F) -> Self {
@@ -280,7 +280,7 @@ where
     }
 }
 
-ref_field_trait_impl!{
+ref_field_trait_impl! {
     impl<F: FieldOps + FieldRandom> Curve for LegendreCurve<F> {
         type BaseField = F;
         type Point = LegendrePoint<F>;

ec/src/curve_montgomery.rs

@@ -35,9 +35,9 @@
 //! scalar multiplication.
 
 use core::fmt;
-use subtle::{Choice, ConditionallySelectable, ConstantTimeEq};
-use fp::{ref_field_impl, ref_field_trait_impl};
 use fp::field_ops::{FieldOps, FieldRandom};
+use fp::{ref_field_impl, ref_field_trait_impl};
+use subtle::{Choice, ConditionallySelectable, ConstantTimeEq};
 
 use crate::curve_ops::Curve;
 use crate::point_montgomery::KummerPoint;
@@ -55,7 +55,6 @@ pub struct MontgomeryCurve<F: FieldOps> {
     pub b: F,
 }
 
-
 impl<F> fmt::Display for MontgomeryCurve<F>
 where
     F: FieldOps + fmt::Display,
@@ -93,7 +92,7 @@ where
     }
 }
 
-ref_field_impl!{
+ref_field_impl! {
     impl<F> MontgomeryCurve<F> {
         // -------------------------------------------------------------------
         // Constructor
@@ -162,7 +161,6 @@ ref_field_impl! {
     }
 }
 
-
 // -------------------------------------------------------------------
 // Curve predicates
 // -------------------------------------------------------------------
@@ -256,7 +254,6 @@ ref_field_trait_impl! {
     }
 }
 
-
 // ---------------------------------------------------------------------------
 // Constant-time functionalities
 // ---------------------------------------------------------------------------
@@ -266,9 +263,9 @@ where
     F: FieldOps + Copy,
 {
     fn conditional_select(a: &Self, b: &Self, choice: Choice) -> Self {
-        Self{
-            a: F::conditional_select(& a.a, &b.a, choice),
-            b: F::conditional_select(& a.b, &b.b, choice),
+        Self {
+            a: F::conditional_select(&a.a, &b.a, choice),
+            b: F::conditional_select(&a.b, &b.b, choice),
         }
     }
 
@@ -291,5 +288,7 @@ where
         self.a.ct_eq(&other.a) & self.b.ct_eq(&other.b)
     }
 
-    fn ct_ne(&self, other: &Self) -> Choice { !self.ct_eq(other) }
-}
+    fn ct_ne(&self, other: &Self) -> Choice {
+        !self.ct_eq(other)
+    }
+}

ec/src/curve_ops.rs

@@ -7,8 +7,8 @@
 //! Each concrete curve type chooses its base field and its native point type
 //! through associated types.
 
-use fp::field_ops::FieldOps;
 use crate::point_ops::PointOps;
+use fp::field_ops::FieldOps;
 
 /// Generic elliptic-curve model.
 ///
@@ -48,4 +48,4 @@ pub trait Curve: Sized + Clone + PartialEq + Eq {
     fn identity(&self) -> Self::Point {
         Self::Point::identity(self)
     }
-}
+}

ec/src/curve_twisted_hessian.rs

@@ -22,7 +22,7 @@
 //!
 //! The twisted Hessian curve is nonsingular when
 //!
-//! $$a \neq 0 \quad\text{and}\quad d^3 \neq a.$$ 
+//! $$a \neq 0 \quad\text{and}\quad d^3 \neq a.$$
 //!
 //! # References
 //!