Skip to content

crl: fix clippy::question_mark finding#516

Merged
cpu merged 1 commit into
rustls:mainfrom
cpu:rust-1.97-clippy-fix
Jul 9, 2026
Merged

crl: fix clippy::question_mark finding#516
cpu merged 1 commit into
rustls:mainfrom
cpu:rust-1.97-clippy-fix

Conversation

@cpu

@cpu cpu commented Jul 9, 2026

Copy link
Copy Markdown
Member

Fixes a failing ci task w/ Rust 1.97 of the form:

error: this `match` expression can be replaced with `?`
   --> src/crl/types.rs:357:13
    |
357 | /             match revoked_cert_result {
358 | |                 Err(e) => return Err(e),
359 | |                 Ok(revoked_cert) => {
360 | |                     if revoked_cert.serial_number.eq(serial) {
...   |
364 | |             }
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#question_mark
    = note: `-D clippy::question-mark` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::question_mark)]`

Of the form:

```
error: this `match` expression can be replaced with `?`
   --> src/crl/types.rs:357:13
    |
357 | /             match revoked_cert_result {
358 | |                 Err(e) => return Err(e),
359 | |                 Ok(revoked_cert) => {
360 | |                     if revoked_cert.serial_number.eq(serial) {
...   |
364 | |             }
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#question_mark
    = note: `-D clippy::question-mark` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::question_mark)]`
```
@cpu cpu self-assigned this Jul 9, 2026
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.64%. Comparing base (3d9f011) to head (d30313a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   97.64%   97.64%   -0.01%     
==========================================
  Files          20       20              
  Lines        4072     4070       -2     
==========================================
- Hits         3976     3974       -2     
  Misses         96       96              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cpu cpu added this pull request to the merge queue Jul 9, 2026
Merged via the queue into rustls:main with commit eda3930 Jul 9, 2026
23 checks passed
@cpu cpu deleted the rust-1.97-clippy-fix branch July 9, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants