Faster DNS name validation#112
Merged
Merged
Conversation
ctz
reviewed
Jul 22, 2026
ctz
left a comment
Member
There was a problem hiding this comment.
Can we have both the performance the formal state-machine type? What happens if we have the state machine type without the large fields?
djc
force-pushed
the
faster-name-validation
branch
from
July 22, 2026 13:18
8bae56c to
5f88476
Compare
Member
Author
Here's a new version that I largely wrote myself. It's a little faster still: |
djc
force-pushed
the
faster-name-validation
branch
from
July 22, 2026 13:19
5f88476 to
54c55d7
Compare
ctz
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at benchmark results for
I noticed that
rustls_pki_types::server_name::validate()was more expensive than I expected. Worked with Claude to optimize it (and verify that it has the same results). Criterion results from this improvement: