fix(win32): ensure window type is always set when using WS_EX_TOPMOST - #4659
Merged
Merged
Conversation
TechnoPorg
force-pushed
the
push-zkwpxwyvztsx
branch
from
August 6, 2026 17:24
b52fb43 to
35e2194
Compare
Contributor
Author
|
The failed job appears related to the GitHub outage yesterday and not these changes. |
TechnoPorg
force-pushed
the
push-zkwpxwyvztsx
branch
3 times, most recently
from
August 16, 2026 11:38
d3044ea to
ef9feb4
Compare
TechnoPorg
force-pushed
the
push-zkwpxwyvztsx
branch
from
September 10, 2026 12:06
ef9feb4 to
485e775
Compare
Contributor
Author
|
@kchibisov would you or anyone else from the org be able to review this? Very sorry for the ping, but I haven't been able to find a better way to request a review. Thanks! |
ogoffart
reviewed
Sep 10, 2026
TechnoPorg
force-pushed
the
push-zkwpxwyvztsx
branch
from
September 10, 2026 22:35
485e775 to
c5a3522
Compare
Contributor
Author
|
Given that it's not getting past the toolchain installation, the Windows CI breakage seems unrelated to this change? |
ogoffart
approved these changes
Sep 12, 2026
Contributor
Author
|
Wonderful, thank you! Would it be okay if I were to open a PR backporting this change to 0.30.x, since that's what's used by iced and where I originally ran into the bug? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelogmodule if knowledge of this change could be valuable to usersThis fixes a bug I encountered in iced with a window having both always-on-top and borderless fullscreen enabled, which would cause DX12 surface creation to crash with this message:
As per this StackOverflow question with debug layer output and this DXVK issue, setting
WS_EX_TOPMOSTrequires that some other window style be set as well; however, previously, the window style would be unset when the fullscreen flag was set. I'm reasonably confident that setting WS_POPUP is correct here, since WS_CAPTION creates a border and that's obviously undesired for borderless fullscreen.I'd also love to see this backported to 0.30.x if possible, but I understand if it's not.