Modal Dialog - #4627
Draft
Murmele wants to merge 9 commits into
Draft
Modal Dialog#4627Murmele wants to merge 9 commits into
Murmele wants to merge 9 commits into
Conversation
Was that #4543 ? |
Contributor
Author
Yes it was |
Murmele
force-pushed
the
mm/modal-dialog
branch
from
September 15, 2026 06:18
3a46b55 to
8ac3fb9
Compare
Extract the logic shared by Window and Popup into a common `WindowCommon` struct (window/common.rs), so `CoreWindow` implementations become thin delegation to shared code instead of duplicating it per window type. Popup is rewired to use it instead of its own separate implementations. Split the large window/state.rs into focused submodules along existing seams: window_type.rs (the WindowType enum and its trait impls), configure.rs (configure_window/configure_popup and the shared frame/size computation), cursor.rs (cursor and pointer-grab handling), frame.rs (CSD frame interaction and decoration state), and ime.rs (IME/text-input state). This is purely internal restructuring with no behavior change; it exists to make adding further window types (e.g. dialogs) straightforward without duplicating logic across each one. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Implement native dialog windows on Wayland (via the xdg_dialog protocol, built on the WindowCommon/WindowType infrastructure from the previous commit) and on Windows (an owned window that's always on top of its parent; when modal, the parent is disabled via EnableWindow for as long as the dialog is open, and re-enabled and reactivated on close). macOS, X11, Web, Android, iOS, and Orbital return NotSupportedError for WindowType::Dialog, matching the existing Popup convention. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
#Conflicts: # winit-wayland/src/window/state/frame.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement modal dialogs. This branch is based on the work of the Popup branch so this must be merged first. Only the last commit here is relevant for dialog
changelogmodule if knowledge of this change could be valuable to usersWhat is missing to be ready
Os