Skip to content

Always send RedrawEventsCleared#2218

Merged
kchibisov merged 3 commits into
rust-windowing:masterfrom
HackerFoo:ios-always-send-redraw-events-cleared
Apr 11, 2022
Merged

Always send RedrawEventsCleared#2218
kchibisov merged 3 commits into
rust-windowing:masterfrom
HackerFoo:ios-always-send-redraw-events-cleared

Conversation

@HackerFoo

@HackerFoo HackerFoo commented Mar 15, 2022

Copy link
Copy Markdown
Contributor

For all platforms other than iOS, RedrawEventsCleared is sent even if there are no redraw events. This change makes iOS consistent with the other platforms.

This solves a bug on iOS where Bevy relies on this event in bevyengine/bevy#3974

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@kchibisov kchibisov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add changelog entry for fixing that?

@HackerFoo
HackerFoo force-pushed the ios-always-send-redraw-events-cleared branch from 67a16b7 to 4199843 Compare April 10, 2022 00:53
@kchibisov kchibisov added this to the Version 0.27 milestone Apr 11, 2022
@kchibisov
kchibisov merged commit 142d55f into rust-windowing:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants