Skip to content

ci: fail on clippy warnings#191

Merged
DCjanus merged 2 commits into
rust-syndication:masterfrom
DCjanus:ci/deny-rust-warnings
Jul 2, 2026
Merged

ci: fail on clippy warnings#191
DCjanus merged 2 commits into
rust-syndication:masterfrom
DCjanus:ci/deny-rust-warnings

Conversation

@DCjanus

@DCjanus DCjanus commented Jul 2, 2026

Copy link
Copy Markdown
Member

Why

Dependency updates can surface warnings that are easy to miss during review.

What

  • Make the clippy job fail on warnings.
  • Replace the deprecated quick-xml attribute value API with the normalized API.

Evidence

The commits keep the CI gate and warning fix separate.

  • 04896bb: only updates the clippy command; the existing quick-xml deprecation warning fails the job: failure.
  • fb7f4a9: updates the attribute API; the same clippy job passes: success.

Assisted-by: Codex:gpt-5.5
@DCjanus DCjanus force-pushed the ci/deny-rust-warnings branch from 412e0d1 to 04896bb Compare July 2, 2026 16:23
@DCjanus DCjanus changed the title ci: fail on Rust warnings ci: fail on clippy warnings Jul 2, 2026
@DCjanus DCjanus marked this pull request as ready for review July 2, 2026 16:32
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.98%. Comparing base (8598600) to head (fb7f4a9).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   80.98%   80.98%           
=======================================
  Files          23       23           
  Lines        1530     1530           
=======================================
  Hits         1239     1239           
  Misses        291      291           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DCjanus DCjanus merged commit b796ac2 into rust-syndication:master Jul 2, 2026
23 checks passed
@DCjanus DCjanus deleted the ci/deny-rust-warnings branch July 2, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant