ipnetwork: Deserialize str instead of allocating#45
Open
joshuamegnauth54 wants to merge 1 commit into
Open
Conversation
Member
|
Hello, and thank you for the contribution. I may be mistaken but it looks like that you didn't use |
Currently, `ipnetwork` always allocates during deserialization. This is unfortunate because ownership isn't needed to construct any of `ipnetwork`'s types. I implemented a small Visitor that opportunistically deserializes from a str borrowed from the deserializer. For some formats, this should help zero alloc deserialization. While some formats will still allocate and pass the deserializer a &str, this Visitor still avoids the second alloc from String in the original.
joshuamegnauth54
force-pushed
the
ipnetwork-serde-borrow
branch
from
46ca21a to
e7f086c
Compare
Author
|
Hi! Sorry, I totally missed the notification for your comment. You're right that I formatted with stable Anyway, I formatted with nightly and force pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
ipnetworkalways allocates during deserialization. This is unfortunate because ownership isn't needed to construct any ofipnetwork's types.I implemented a small Visitor that opportunistically deserializes from a str borrowed from the deserializer. For some formats, this should help zero alloc deserialization. While some formats will still allocate and pass the deserializer a &str, this Visitor still avoids the second alloc from String in the original.