Skip to content

add missing {forward,backward}_overflowing impls#595

Merged
Freax13 merged 1 commit into
rust-osdev:masterfrom
tpdenk:master
Jul 10, 2026
Merged

add missing {forward,backward}_overflowing impls#595
Freax13 merged 1 commit into
rust-osdev:masterfrom
tpdenk:master

Conversation

@tpdenk

@tpdenk tpdenk commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Cause: rust-lang/rust#155114

One problem: Kani bundles nightly-2025-11-21 (their main bundles nightly-2025-12-31 as of 2026-07-09 (yesterday at the time of writing) as per model-checking/kani#4624), meaning I can't add Kani proofs. Once they bundle nightly-2026-07-10 or later, you can do this: https://github.com/rust-osdev/x86_64/compare/4bc97dadf4481e6d8ce858c0ca6413e351322c12..9bf986f2282f691ccc856087bf7a86cd41316c03 (without disabling Kani of course).

Fixes #594

@zhangxuan2011

zhangxuan2011 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

ref #594

Haha, Just find this problem several hrs ago, and a PR was came out quickly :))) (my eng not good)

@tpdenk

tpdenk commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Today is the first day this problem even exists from what I can tell.
If you have a project that relies on nightly and breakages like these are really critical for you, you should really pin your nightly version (I've updated #594 (comment))

@zhangxuan2011

Copy link
Copy Markdown
Contributor

Today is the first day this problem even exists from what I can tell. If you have a project that relies on nightly and breakages like these are really critical for you, you should really pin your nightly version (I've updated #594 (comment))

I did, but this is the temporary fix for now.

@tpdenk

tpdenk commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

https://github.com/tpdenk/x86_64/actions/runs/29087392922/job/86344256732

Seems like semver checks uses rust stable? Idk why it does, but that's obv going to fail.

@zhangxuan2011

Copy link
Copy Markdown
Contributor

https://github.com/tpdenk/x86_64/actions/runs/29087392922/job/86344256732

Seems like semver checks uses rust stable? Idk why it does, but that's obv going to fail.

idk the author will update it or not...

@Freax13 Freax13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

I had one small question, once resolved, this PR should be ready to be merged.

Comment thread src/addr.rs Outdated

@Freax13 Freax13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :shipit:

@Freax13 Freax13 enabled auto-merge July 10, 2026 17:21
@Freax13 Freax13 merged commit 5e95d2f into rust-osdev:master Jul 10, 2026
12 of 13 checks passed
@zhangxuan2011

Copy link
Copy Markdown
Contributor

LGTM, thanks! :shipit:

So i hope the new version of this crate will be published as soon as possible😄👏

@Freax13 Freax13 mentioned this pull request Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compile error in recent nightly version

3 participants