Upgrade rand to 0.9#322
Closed
divergentdave wants to merge 5 commits into
Closed
Conversation
Contributor
|
Is this already discussed in #317? |
Author
|
Yes, but this PR is limited to upgrading the rand dependency, excluding additional clippy suggestions. |
|
Hi @cuviper, do you have time to take a look at this? This will disrupt our community's efforts to migrate to Rand 0.9. Or do we have other committers who can check it out? |
|
Would be great to see this merged in. |
|
+1 |
Contributor
|
I've suggested we cut a release with this merged before #338, so that there's a release available with a MSRV of 1.63. |
Closed
Member
|
The rand upgrade is done in #338 and published 0.5.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the crate version, MSRV, and
randdependency. I also changed some panics into errors in trait methods that are now fallible, and renamed the methods ofRandBigIntto align with changes in theRngtrait.