Display our own message when CI checks are not green for enqueuing PR#2449
Display our own message when CI checks are not green for enqueuing PR#2449Urgau wants to merge 1 commit into
Conversation
|
Shouldn't it be possible to use "Merge when ready" using the GraphQL call? That sounds much more practical than displaying an error message and forcing the user to wait. |
|
Seems like it would be possible with |
|
I don't think so, I remember that I sometimes enable it on bors and then push a few times until CI passes. That might be preventable by requiring a review of the most recently pushed commit though. It just seems nicer to do what the UI could already do for you, rather than forcing the user to retry, which is an annoyance (same in bors, where we would someday like to automate the "r=me once CI is green" workflow). |
|
I'm fine changing it, if @samueltardieu agrees. |
|
Do we get a webhook when CI fails? Would it be possible to disable auto-merge then? That could be good in general, both in the context of rustbot merge and in the context of a manual auto-merge. |
|
We probably get one, but I don't think that's necessary, as GitHub disable auto-merge when new changes are pushed by a non-member. |
|
Continuing in #2450 |
This PR adds a small logic to detect and display our own message when CI checks are not green when trying to enqueue PR (
rustbot mergecommand).Unfortunately GitHub doesn't give us any code or information about the failure it-self other than the error message it-self, so we have to do some matching on them, let's hope those error messages don't change too often.
cc @samueltardieu