Skip to content

Pin GitHub API version in our GitHub client#2447

Merged
apiraino merged 1 commit into
rust-lang:masterfrom
apiraino:pin-gh-api-version
Jun 30, 2026
Merged

Pin GitHub API version in our GitHub client#2447
apiraino merged 1 commit into
rust-lang:masterfrom
apiraino:pin-gh-api-version

Conversation

@apiraino

@apiraino apiraino commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

The current GitHub API version ("2022-11-28") we use will be deprecated in about 2 years from now, so at some point we should start testing the new version.
Our client is just a part of the story because we heavily use the octocrab crate (I don't know what is the situation there).
I thought about adding a check and a "reminder".

GitHub blog post: https://docs.github.com/en/rest/about-the-rest-api/breaking-changes?apiVersion=2026-03-10#version-2026-03-10

Zulip discussion: https://rust-lang.zulipchat.com/#narrow/channel/224082-triagebot/topic/New.20GitHub.20API.20version/near/579038018

What do you think? Can this be helpful?

r? @Kobzol / @Mark-Simulacrum

thanks

The current API version we use will be deprecated in about 2 years from now, so at some point we should
start testing the new version.

Our client is just a part of the story because we heavily use the `octocrab` crate (I don't know what is
the situation there).

@Mark-Simulacrum Mark-Simulacrum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems not unreasonable, though I guess bumping to latest and seeing what happens is probably the best we can do (at least for triagebot).

View changes since this review

@Kobzol Kobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you. If we forget, this will at least clearly notify us that something is wrong :)

View changes since this review

@apiraino apiraino added this pull request to the merge queue Jun 30, 2026
Merged via the queue into rust-lang:master with commit c77b369 Jun 30, 2026
3 checks passed
@apiraino apiraino deleted the pin-gh-api-version branch June 30, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants