Skip to content

Tell the user that nothing changed rather than a cryptic GitHub message#2446

Merged
Urgau merged 1 commit into
rust-lang:masterfrom
Urgau:gh-changes-since-no-changes
Jun 29, 2026
Merged

Tell the user that nothing changed rather than a cryptic GitHub message#2446
Urgau merged 1 commit into
rust-lang:masterfrom
Urgau:gh-changes-since-no-changes

Conversation

@Urgau

@Urgau Urgau commented Jun 24, 2026

Copy link
Copy Markdown
Member

Instead of redirecting the user to GitHub's compare view when nothing changed in our "View changes this review" link, show a clear message, instead of the cryptic GitHub message.

GitHub compare This PR
image image

cc @camelid

@Urgau Urgau requested a review from Kobzol June 24, 2026 17:09
Comment thread src/gh_changes_since.rs Outdated
Comment thread src/gh_changes_since.rs Outdated
@Urgau Urgau force-pushed the gh-changes-since-no-changes branch from fec0209 to 9268ba7 Compare June 26, 2026 15:49

@Kobzol Kobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a person who routinely switches between 5 different PRs and continuously opens tabs in the background, I'd appreciate if the page contained a link to the original PR, so that I can find what PR is the page referring to 😆

View changes since this review

@Urgau Urgau force-pushed the gh-changes-since-no-changes branch from 9268ba7 to 2021073 Compare June 29, 2026 15:55
@Urgau

Urgau commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

I'd appreciate if the page contained a link to the original PR

Added, in the same as GitHub: "Head back to the latest changes here."

@Urgau Urgau added this pull request to the merge queue Jun 29, 2026
Merged via the queue into rust-lang:master with commit 58c2658 Jun 29, 2026
3 checks passed
@Urgau Urgau deleted the gh-changes-since-no-changes branch June 29, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants