Skip to content

Stop unconditionnaly remove some UI tests directories #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antoyo merged 1 commit into from
Jul 17, 2026
Merged

Stop unconditionnaly remove some UI tests directories #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions build_system/src/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1022,21 +1022,6 @@ where
true,
)?;
} else {
walk_dir(
rust_path.join("tests/ui"),
&mut |dir| {
let dir_name = dir.file_name().and_then(|name| name.to_str()).unwrap_or("");
if ["abi", "extern", "proc-macro", "threads-sendsync"].contains(&dir_name) {
remove_dir_all(dir).map_err(|error| {
format!("Failed to remove folder `{}`: {:?}", dir.display(), error)
})?;
}
Ok(())
},
&mut |_| Ok(()),
false,
)?;

// These two functions are used to remove files that are known to not be working currently
// with the GCC backend to reduce noise.
fn dir_handling(keep_lto_tests: bool) -> impl Fn(&Path) -> Result<(), String> {
Expand Down
5 changes: 5 additions & 0 deletions tests/failing-ui-tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,3 +104,8 @@ tests/ui/eii/static/default_cross_crate.rs
tests/ui/eii/static/default_explicit.rs
tests/ui/eii/static/default_cross_crate_explicit.rs
tests/ui/explicit-tail-calls/tailcc-no-signature-restriction.rs
tests/ui/abi/rust-tail-cc.rs
tests/ui/abi/rust-preserve-none-cc.rs
tests/ui/abi/stack-protector.rs
tests/ui/extern/extern-types-field-offset.rs
tests/ui/abi/stack-probes-lto.rs
Loading