Support guaranteed tail calls#911
Merged
Merged
Conversation
folkertdev
commented
Jul 16, 2026
| } else { | ||
| #[cfg(not(feature = "master"))] | ||
| if gcc_func.get_param_count() == 0 { | ||
| // FIXME(antoyo): As a temporary workaround for unsupported LLVM intrinsics. |
Contributor
Author
There was a problem hiding this comment.
is this workaround still needed? I think this code can be refactored a bunch (sharing this assignment logic between direct and pointer calls) if it is now redundant.
Contributor
There was a problem hiding this comment.
You can try removing this code, but I believe this refers to some intrinsics that we translate to __builtin_trap because it's not yet supported, so this is likely still needed.
A refactor could possibly allow us to remove this hack, though.
Contributor
Author
There was a problem hiding this comment.
well if you're ok with the changes then you can merge this. I made a separate PR to check if CI fails with that hack removed
folkertdev
force-pushed
the
guaranteed-tail-calls
branch
from
July 16, 2026 20:33
9bce153 to
6b91439
Compare
folkertdev
force-pushed
the
guaranteed-tail-calls
branch
from
July 16, 2026 20:34
6b91439 to
61a02cd
Compare
folkertdev
marked this pull request as ready for review
July 16, 2026 20:35
antoyo
approved these changes
Jul 16, 2026
Contributor
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for
becomeusing GCC'smusttailimplementation. Depends onset_require_tail_callgccjit.rs#71