implement va_start and va_arg#906
Open
folkertdev wants to merge 1 commit into
Open
Conversation
antoyo
reviewed
Jul 12, 2026
|
|
||
| // Tests defining and calling C-variadic functions (reading arguments via `VaList`). | ||
| // | ||
| // Based on tests/ui/c-variadic/roundtrip.rs from rust-lang/rust. |
Contributor
There was a problem hiding this comment.
Does this test pass?
If so, we can remove it from this file instead.
Contributor
Author
There was a problem hiding this comment.
It should, assuming everything is synchronized. I just removed some i128 logic that just got added a couple of days ago in the main repo and hasn't yet been synchronized back. With the other two PRs merged we can try it in CI here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on
va_argandva_startgcc#84new_va_argandVaListgccjit.rs#70