Skip to content

Add newline before stat title in GH summary#1330

Merged
rylev merged 1 commit into
masterfrom
gh-summary-fix
May 19, 2022
Merged

Add newline before stat title in GH summary#1330
rylev merged 1 commit into
masterfrom
gh-summary-fix

Conversation

@Kobzol

@Kobzol Kobzol commented May 19, 2022

Copy link
Copy Markdown
Member

This is a hotfix for #1322, as it has some weird formatting. Hopefully this fixes it.

@Kobzol
Kobzol requested a review from rylev May 19, 2022 08:17

@rylev rylev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if your suggestion or mine is the better way to fix it, thoughts?

(FYI: I manually edited the broken comment linked in this PR)

Comment thread site/src/github.rs Outdated
@Kobzol

Kobzol commented May 19, 2022

Copy link
Copy Markdown
Member Author

I removed the summary heading, changes headers to <h3> (###) and added the newline.

@rylev
rylev merged commit 898c46f into master May 19, 2022
@rylev
rylev deleted the gh-summary-fix branch May 19, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants