Rollup of 7 pull requests - #162938
Closed
Zalathar wants to merge 18 commits into
Closed
Rollup of 7 pull requests#162938Zalathar wants to merge 18 commits into
Zalathar wants to merge 18 commits into
Conversation
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
there's no need to wrap the value at runtime to visit it
- fix margins - ensure the MIR code wraps instead of needing scrollbars - defocus the trace suffixes
Add Natvis visualiser and debuginfo tests for `f128`
To render f128s in debuggers on MSVC targets, this PR changes the compiler to output `f128`s as `struct f128 { low_bits: u64, high_bits: u64 }`, and includes a Natvis visualiser that displays the float in hexdecimal format (similar to the `LowerHex` impl in rust-lang#160626), as unlike `f16` there's no larger supported float format to convert to and trying to write a float to decimal string converter in Natvis didn't seem practical. gdb, lldb and cdb tests are also included for `f128`, although gdb does not yet correctly identify the float format.
I did consider also displaying a `double` approximation of the `f128` (as the debugger will convert that to a decimal string) but decided against it as `f64` has a significantly smaller exponent range too (meaning very large or small `f128`s couldn't have an approximation anyway) and `cdb` and `WinDbg` both seem to round all floating-point numbers to 6 decimal places, meaning the displayed number is (double) rounded even further than `f64` precision and is useless for tiny values.
Closes rust-lang#121837
Tracking issue: rust-lang#116909
Fix docs of make_ascii_lowercase/make_ascii_upercase Currently the documentation (but the example) does not specify what happens to ascii characters that are not A-Z. This fixes the documentation to specify that all non A-Z characters are left untouched.
…emathas Add mentions to sync back `RELEASES.md` to the `main` branch I think this can be useful, we had several times in the past incident where the releases notes where not in sync with the `main` branch, which delayed the GitHub releases. One thing to note: triagebot mentions always runs on all the branches, so I had to make the message more generic than it could have been.
… r=clarfonthey docs(num): add documentation for `NonZero::from_str` Since `int::from_str` has its own documentation but `NonZero::from_str` does not, I added documentation for `NonZero::from_str` based on the documentation for `int::from_str`. @rustbot label +A-docs
…ests, r=Urgau Move more `rustdoc-html` tests in the right location Follow-up of rust-lang#162372. r? @Urgau
An assortment of polonius tweaks As discussed on zulip, r? @jackh726 this contains a couple tweaks: - fixes the variance recording to be done at the expected two places instead of three (it should be idempotent, but as we saw with unexpected variance, better safe than sorry) - cleans it up to also match with the deferred liveness work - starts adding some features from my polonius mir dump prototypes (here, just some simple navigation QoL additions) - improves the visuals slightly again (details in the commits; but mostly as you can see [in this example](https://gistpreview.github.io/?b8b9218f6565f3b13f91a63859ad776e) and [fixed here](https://gistpreview.github.io/?dadb54091b91f34578f58df067c7a77f), some lines in the MIR dump can be huge and that made the viewport scroll, etc)
…oshtriplett Use niche length type for strlen to guarantee `isize::MAX` bound Alternative to rust-lang#162912. r? hanna-kruppe cc @Darksonn
rustbot
added
A-LLVM
Member
Author
|
Rollup of everything. @bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Member
Author
|
rust-bors
Bot
added
the
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
rust-bors
Bot
removed
the
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
f128#161777 (Add Natvis visualiser and debuginfo tests forf128)RELEASES.mdto themainbranch #162256 (Add mentions to sync backRELEASES.mdto themainbranch)NonZero::from_str#162803 (docs(num): add documentation forNonZero::from_str)rustdoc-htmltests in the right location #162906 (Move morerustdoc-htmltests in the right location)isize::MAXbound #162930 (Use niche length type for strlen to guaranteeisize::MAXbound)r? @ghost
Create a similar rollup