Rollup of 8 pull requests - #162869
Closed
JonathanBrouwer wants to merge 20 commits into
Closed
Rollup of 8 pull requests#162869JonathanBrouwer wants to merge 20 commits into
JonathanBrouwer wants to merge 20 commits into
Conversation
Giving access to `std::os::windows::process::ChildExt::main_thread_handle()`.
It does not look like these items are actually used by rustc.
This is to make it easy to update the static template, like its skeleton or style, and add features there, instead of doing it all with rust code. The dynamic sections are marked as dummy tokens and are replaced when dumping the MIR.
display a list of all the nodes each loan can reach (and whether the node's region is live at the node's point)
Loan traces can be big and numerous, so we hide them by default. We instead use a button to show a loan's trace.
margins and spacing, section separators, reachability layout, etc.
This API is in FCP, but there are no examples and much of it is untested. Add examples here.
Co-authored-by: Amanda Stjerna <amanda@stjerna.space> Co-authored-by: Jack Huey <31162821+jackh726@users.noreply.github.com>
LLVM prior to 24 didn't do some optimizations around call slots on pointers without `dereferenceable` set. A recent change enhanced the optimizer so it can handle that case (at least in this test) so we relax the checks here slightly. We still (from what I can tell) demonstrate that `sse41_blend_nofeature` is not inlined, which seems to be the import part of this region of the test.
…oli-obk libtest: do not early exit from test runners Suggested by @Mark-Simulacrum in rust-lang#161868. I finally figured out why my earlier attempts did not work.
Add loan reachability traces to polonius MIR dumps This expands the Polonius MIR dumps to add traces of all the nodes a loan traverses (and if the region it reaches is live at that point). This helps with debugging and analyzing borrow-checking, of soundness issues in particular, as they manifest as a *lack* of reachability in the localized outlives graph. Since there can be many loans and the traces can be big, they're hidden by default until a button is clicked. I've uploaded an [example here](https://gistpreview.github.io/?b8b9218f6565f3b13f91a63859ad776e) so it's easier to test. <sub>This feels like a good enough start, but there's definitely many expansions I'd like to make to this feature in future PRs. Some of which I've already done in [older prototypes](https://gistpreview.github.io/?4098d51d4f4e12e2a61a673b60d94690).</sub> More easily reviewed per commit. r? @jackh726 (also cc @amandasystems as we were all discussing things like this to help with the unsoundness analyses)
…fonthey Guarantee 8 bytes of alignment of RawWakerVTable This is similar to an earlier PR I made for `Thread::into_raw`: rust-lang#143859. When using `AtomicPtr` for synchronization it's incredibly useful when you've got a couple bits you can stuff metadata in. By guaranteeing that `RawWakerVTable` is aligned to 8 bytes everyone can use the bottom 3 bits to signal other things, such as a critical section, etc. In particular, this can be used to portably implement an `AtomicWaker` which is always two pointers in size, no more. On almost all platforms the align is already 8 bytes, and on other platforms it might cause an infinitesimal increase in size. This guarantee is thus very useful and costs us essentially nothing. --- r? libs-api Like last time since this adds a guarantee this probably needs a FCP.
…ead-windows, r=clarfonthey Stabilize `windows_process_extensions_main_thread_handle` I propose we stabilize the library feature `windows_process_extensions_main_thread_handle` (tracking issue rust-lang#96723). ## Stabilization Report ### Implementation History This feature was added in rust-lang#96725, and not changed since. ### API Summary ```rust // std::os::windows::process pub trait ChildExt: Sealed { fn main_thread_handle(&self) -> BorrowedHandle<'_>; } ``` This method gives access to the handle to the main thread of a spawned child process on Windows. It is not possible to get after spawning using documented APIs, and it's useful for example for resuming a process that started as suspended (while it's possible to enumerate all threads and resume them all, that's slower and more complicated). ### Experience Report My personal reason for this is wanting to use it for this case exactly (resuming a suspended process) in rust-analyzer, see rust-lang/rust-analyzer#22763 (comment). Other people seem to want this for the same reason as well (for example in the tracking issue). [Searching GitHub for `.main_thread_handle()` gives 269 results](https://github.com/search?q=%22.main_thread_handle%28%29%22+language%3Arust&type=code). Some are for resuming processes, but there are also others - for example, [injecting a DLL](https://github.com/garyttierney/me3/blob/a1e26958d8e141864d3adfcbbef4f2f669b5c8ef/crates/launcher/src/game.rs#L98). I [even found a project](https://github.com/GitFlameAI/GitFlame-CodeRAG/blob/3684d2dc846831f9805bec4486e60296c232f974/datasets/repositories/repo_020_hyperfine/code/src/timer/windows_timer.rs#L71) that gates using this method behind a feature, and if it's not set, uses an undocumented Windows API instead. ### Unresolved Questions There are two unresolved questions: - The naming - should it be the "main thread" or the "primary thread". Microsoft's documentation refers to it as the "primary thread", but our own docs mention "main thread" (https://doc.rust-lang.org/std/thread/index.html), as stated in rust-lang#96723 (comment). I left it as "main thread". - Should it return `Option<BorrowedHandle<'_>>`? This will enable conversion from a handle to `std::process::Child` (such conversion is not supported currently). Such conversion is not supported for any OS currently though, and making this function returning `Option` will complicate code using it, so I chose to not do that. r? libs-api
…jackh726 Use the entire type of a dropped local to compute variance (edge direction) for Polonius alpha Fixes: rust-lang#160670 The soundness issue is caused by (as suggested by the text extruder) the incorrect variance for a region, which is supposed to be bidirectional (invariant) but is registered as contravariant. Starting with this example (from the issue): ```rust use std::fmt::Debug; struct D<T: HasArg>(T::Arg); trait HasArg { type Arg: Debug; } impl<'a, T: Debug> HasArg for fn(&'a T) { type Arg = &'a T; } impl<T: HasArg> Drop for D<T> { fn drop(&mut self) { println!("{:?}", self.0); } } fn mk<'a, T: Debug>(r: &'a T) -> D<fn(&'a T)> { D(r) } fn main() { let b = Box::new(vec![vec![1]]); let d; d = mk(&*b); drop(b); // ERROR: move out of borrowed... } ``` This generates a path through MIR on the way to a drop that looks like this: ```MIR _1 = move _2 /// ... drop(_1) ``` In this instance, the types of `_1` and `_2` are `D<fn(&'?1 Vec<...>)` and `D<fn(&'?2 Vec<...>)` respectively. During liveness computation (in `liveness::trace`) region liveness is computed from drop liveness and use liveness. Additionally, for each live region (drop-live or use-live), region variance is computed for Polonius' loan propagation. Variance determines the direction of propagation across program flow. For drop-live locals (variables), the types reported in ` DropckOutlivesResult::kinds` are used to register drop live regions and compute their variances. However, instead of using the full type `D<...>` for the left-hand side of this assignment statement, `kinds` starts with a `Binder {...}` and the function type inside of it. From that it finds region `'?1` and records it as contravariant (backwards propagated). This PR addresses the issue by using the entire type of the drop-live local to compute the variance of any regions referenced inside it, at the cost of potentially doing unnecessary extra work, ~~either when iteration continues over `DropckOutlivesResult::kinds` (which should be redundant with it in most cases), or~~ if the local contains a region whose variance is actually not needed for computation or in regard to drop liveness (assuming that ever happens). It also adds some debug statements that helped me debug the issue, and a ui test for the soundness issue.
…rget-feature, r=nikic tests: accept LLVM 24 optimization in this test LLVM prior to 24 didn't do some optimizations around call slots on pointers without `dereferenceable` set. A [recent change](llvm/llvm-project@8a4a0f26704b) enhanced the optimizer so it can handle that case (at least in this test) so we relax the checks here slightly. We still (from what I can tell) demonstrate that `sse41_blend_nofeature` is not inlined, which seems to be the import part of this region of the test. @rustbot label: +llvm-main
…=clarfonthey core: Add examples for `debug_closure_helpers` This API is in FCP, but there are no examples and much of it is untested. Add examples here.
…ow-window, r=jhpratt Stabilize CommandExt::show_window Stabilize `std::os::windows::process::CommandExt::show_window`. The final comment period of rust-lang#127544 was completed. rust-lang#127544 (comment) I have been using this function for 2 years. I want to use this function on stable Rust. So, I open a pull request. `windows_process_extensions_show_window` feature appears only in the location I modified. ``` > rg 'windows_process_extensions_show_window' src/tools/rust-analyzer/crates/ide-db/src/generated/lints.rs 17165: label: "windows_process_extensions_show_window", 17166: description: r##"# `windows_process_extensions_show_window` library/std/src/os/windows/process.rs 191: #[stable(feature = "windows_process_extensions_show_window", since = "CURRENT_RUSTC_VERSION")] ``` LLM disclosure: I asked an ChatGPT for the steps and manually created a commit. I handled the searching for the code to modify (using `rg`) and the actual editing (using `nano`) myself.
rustbot
added
O-windows
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 16, 2026
Rollup of 8 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-gnu-llvm-21-3 try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 16, 2026
…uwer Rollup of 8 pull requests Successful merges: - #162796 (libtest: do not early exit from test runners) - #162844 (Add loan reachability traces to polonius MIR dumps) - #158186 (Guarantee 8 bytes of alignment of RawWakerVTable) - #160108 (Stabilize `windows_process_extensions_main_thread_handle`) - #161305 (Use the entire type of a dropped local to compute variance (edge direction) for Polonius alpha) - #161838 (tests: accept LLVM 24 optimization in this test) - #162825 (core: Add examples for `debug_closure_helpers`) - #162856 (Stabilize CommandExt::show_window)
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 9ba947a failed: CI. Failed job:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot)Important For more information how to resolve CI failures of this job, visit this link. |
Contributor
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
PR #158186, which is a member of this rollup, was unapproved. |
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
windows_process_extensions_main_thread_handle#160108 (Stabilizewindows_process_extensions_main_thread_handle)debug_closure_helpers#162825 (core: Add examples fordebug_closure_helpers)r? @ghost
Create a similar rollup